dis: FOR_ITER reports wrong exhausted-path jump target (END_FOR instead of POP_ITER)
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 35.9k
- PR 合併指標
- PR 指標待擷取
描述
Bug Report
Bug description:
In Python 3.15, dis reports the wrong jump target for FOR_ITER when the iterator is exhausted. The reported target lands on END_FOR, but the CPython runtime actually jumps one instruction past it to POP_ITER.
Root cause: In bytecodes.c, FOR_ITER uses JUMPBY(oparg + 1) to skip past END_FOR. However, dis computes the jump target as NIP + oparg * 2 bytes (without the +1), landing on END_FOR rather than POP_ITER.
import dis
def f():
for x in [1, 2, 3]:
pass
instrs = {i.offset: i for i in dis.get_instructions(f.__code__, show_caches=True)}
for i in dis.get_instructions(f.__code__):
if i.opname == "FOR_ITER":
for_iter = i
# dis reports this as the jump target:
reported_target = for_iter.jump_target
reported_name = instrs[reported_target].opname # "END_FOR"
# CPython runtime actually jumps here (oparg+1 instructions past NIP):
nip = for_iter.offset + 4 # 4 bytes = FOR_ITER word + CACHE word
actual_target = nip + (for_iter.arg + 1) * 2
actual_name = instrs[actual_target].opname # "POP_ITER"
print(f"dis reports: offset {reported_target} = {reported_name}") # END_FOR
print(f"runtime jumps: offset {actual_target} = {actual_name}") # POP_ITER
Output:
dis reports: offset 20 = END_FOR
runtime jumps: offset 22 = POP_ITER
The stack-effect model remains self-consistent (FOR_ITER +1, END_FOR -1, POP_ITER -2), but the reported jump target is misleading to any tool that builds a control-flow graph from dis output. The exhausted-iterator edge should point to POP_ITER, not END_FOR.
CPython versions tested on:
CPython main branch (3.15)
Operating systems tested on:
macOS
Linked PRs
- gh-149503
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 bytecodes.c 中的 FOR_ITER 實作以及計算跳躍目標的 dis 進入點開始。比較報告中所述的迭代器耗盡目標與執行時期行為,然後新增回歸測試涵蓋,顯示目標是 POP_ITER 而非 END_FOR。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- devtools
- Issue 類型
- 缺陷
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 活躍度
- 停滯
- 描述清晰度
- 描述清楚
- 新手友好度
- 35/100