Invalid `SHELL` in `Makefile` for AIX builds?
Personne n'a encore pris cette issue.
- Langage dominant
- Python
- Étoiles
- 77.2k
- Forks
- 35.9k
- Métriques de merge des PR
- Métriques de PR en attente
Description
Bug report
Bug description:
When trying to build CPython on AIX, the make steps fails immediately with the following error message:
$ ./configure
[...]
$ make
/bin/sh -e: not found
make: 1254-004 The error code from the last command is 1.
Stop.
AIX make(1) interprets whatever is assigned to the SHELL variable as a file path to the shell. It thus tries to use a shell named "/bin/sh -e":
execve("/bin/sh -e", 0x0000000110004D28, 0x0FFFFFFFFFFFFB90) Err#2 ENOENT
The -e was added by #100220, however I wonder if this is the right approach.
Going by POSIX I think -e should be the default unless it is explicitly disabled:
The execution line shall then be executed by a shell as if it were passed as the argument to the system() interface, except that if errors are not being ignored then the shell -e option shall also be in effect. If errors are being ignored for the command (as a result of the -i option, a '-' command prefix, or a .IGNORE special target), the shell -e option shall not be in effect.
I assume the -e was added for GNU make, which does not set -e unless it is set to POSIX-conforming mode (GNU make: Choosing the shell).
If the Makefile is defined to be a POSIX Makefile, wouldn't it be better to define .POSIX: in the makefile?
Quick test with GNU make:
$ cat Makefile
.POSIX:
SHELL = /bin/sh
test:
false; echo after false
$ make --version
GNU Make 4.4.1
Built for powerpc64le-unknown-linux-musl
Copyright (C) 1988-2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
$ make test
false; echo after false
make: *** [Makefile:4: test] Error 1
CPython versions tested on:
CPython main branch
Operating systems tested on:
Other
Linked PRs
- gh-149022
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
L’issue pointe vers le Makefile et indique que -e a été ajouté par #100220 ; commencez par là et comparez la gestion de SHELL par AIX make avec le comportement POSIX cité. Reproduisez l’échec sur AIX ou examinez le travail lié gh-149022 ; l’achèvement sera indiqué lorsque le Makefile ne transmettra plus de chemin de shell non valide à AIX make.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python, shell
- Domaine
- build-system, operating-systems
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100