test_urllib2.HandlerTests.test_redirect_no_path fails when proxy environment variables are set
Ninguém assumiu esta issue ainda.
- Linguagem predominante
- Python
- Estrelas
- 77.2k
- Forks
- 36k
- Métricas de merge de PRs
- Métricas de PR pendentes
Descrição
Bug report
Bug description:
Running:
./python -m unittest test.test_urllib2.HandlerTests.test_redirect_no_path
can fail in environments where proxy-related variables are set (http_proxy, https_proxy, etc.).
The test output shows below:
F
======================================================================
FAIL: test_redirect_no_path (test.test_urllib2.HandlerTests.test_redirect_no_path)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/yansendao/git/cpython/Lib/test/test_urllib2.py", line 1400, in test_redirect_no_path
fp = urllib.request.urlopen("http://python.org/path")
File "/home/yansendao/git/cpython/Lib/urllib/request.py", line 187, in urlopen
return opener.open(url, data, timeout)
~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
File "/home/yansendao/git/cpython/Lib/urllib/request.py", line 489, in open
response = self._open(req, data)
File "/home/yansendao/git/cpython/Lib/urllib/request.py", line 506, in _open
result = self._call_chain(self.handle_open, protocol, protocol +
'_open', req)
File "/home/yansendao/git/cpython/Lib/urllib/request.py", line 466, in _call_chain
result = func(*args)
File "/home/yansendao/git/cpython/Lib/urllib/request.py", line 1352, in http_open
return self.do_open(http.client.HTTPConnection, req)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/yansendao/git/cpython/Lib/urllib/request.py", line 1323, in do_open
h.request(req.get_method(), req.selector, req.data, headers,
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
encode_chunked=req.has_header('Transfer-encoding'))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/yansendao/git/cpython/Lib/test/test_urllib2.py", line 1395, in request
self.assertEqual(url, next(urls))
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
AssertionError: 'http://python.org/path' != '/path'
- http://python.org/path
+ /path
----------------------------------------------------------------------
Ran 1 test in 0.010s
FAILED (failures=1)
Expected behavior
This test should validate relative redirect behavior (Location: ?query) independently of external shell/network configuration. It should pass regardless of whether proxy env vars are present.
Root cause
urllib.request.urlopen() honors proxy settings from environment variables.
When proxying is enabled, the HTTP request target format changes to absolute-form, which does not match this test’s path-only assertion.
Proposed fix
Make the test environment-independent by clearing proxy-related environment variables inside test_redirect_no_path using EnvironmentVarGuard (both lower/upper case variants, plus no_proxy/NO_PROXY).
Why proxy configuration matters when running tests
Some environments (corporate/campus networks, CI runners) require proxy settings for outbound connectivity; without them, networked tests may fail due to connection/timeouts.
However, logic-focused unit tests should not depend on external proxy state, so they should explicitly isolate themselves from proxy env effects.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
- gh-148920
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Direção de pesquisa
Comece em Lib/test/test_urllib2.py, em HandlerTests.test_redirect_no_path, e revise como o teste usa EnvironmentVarGuard. Execute ./python -m unittest test.test_urllib2.HandlerTests.test_redirect_no_path com as variáveis de proxy definidas e não definidas. Está concluído quando o teste valida o redirecionamento relativo e passa independentemente das configurações do ambiente de proxy.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- python
- Domínio
- testing-qa
- Tipo de issue
- Bug
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Status de atividade
- Estagnada
- Clareza
- Claramente especificada
- Facilidade para iniciantes
- 35/100