python / python/cpython

Dialog about overrun of a stack-based buffer on Windows Server 2022 (caused by `asyncio` / `socket`)

未關閉
#145,899 5 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

extension-modules OS-windows topic-socket type-crash
主要語言
Python
星號
77.2k
分支
35.9k
PR 合併指標
PR 指標待擷取

描述

Crash report

What happened?

On Windows Server 2022, when exiting a Python process, we sporadically get a dialog with the title "python.exe - System Error", which reads "The system detected an overrun of a stack-based buffer in this application. This overrun could potentially allow a malicious user to gain control of this application."

We do not get this error with Windows Server 2019.

The issue is very sporadically. Even with the following reproducers, we only experience the issue every 1,000 to 100,000 runs on our systems.

Our initial reproducer was:

import asyncio  
async def f():  
    pass
asyncio.run(f())

We could narrow it down further to:

import socket
socket.socketpair()

(The issue does also occur if I close the sockets returned from socketpair.)

The issue can also be reproduced with the following snippet extracted from socket.socketpair():

import socket

l = socket.socket()
l.bind(("127.0.0.1",0))
l.listen()

c = socket.socket()
c.setblocking(False)
try:
    c.connect(l.getsockname())
except BlockingIOError:
    pass

Setting the socket to unblocking seems to be essential. I could not reproduce the issue without setting it to unblocking.

Further, calling os._exit() prevents the issue. I digged a little further and found that not calling WSACleanup() in os_cleanup() in socketmodule.c prevents the issue.

CPython versions tested on:

3.11, 3.12, 3.13, 3.14

Operating systems tested on:

Windows

Output from running 'python -VV' on the command line:

No response

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

從 socketmodule.c 中的 os_cleanup() 開始,重點關注 WSACleanup() 呼叫。在 Windows Server 2022 上反覆執行使用 socketpair() 或非阻塞 socket 的最小重現程式,並將行為與 Windows Server 2019 進行比較。完成標準是找出並修正 shutdown 路徑,使 stack-buffer-overrun 對話方塊不再出現。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
networking, operating-systems
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。