python / python/cpython

Convert more uops to leave their inputs on the stack to be cleaned up by `_POP_TOP`

未關閉
#145,866 21 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

3.15 interpreter-core performance topic-JIT type-feature
主要語言
Python
星號
77.2k
分支
36k
PR 合併指標
PR 指標待擷取

描述

Feature or enhancement

Proposal:

This is a follow up to https://github.com/python/cpython/issues/134584

We have, in the JIT, optimizations to eliminate many _POP_TOP operations. To take advantage of that we have converted many uops to leave their operands on the stack and added subsequent _POP_TOPs to remove them.
See https://github.com/python/cpython/issues/134584 for many examples of how to do this and why it works.

However, there are still a few uops yet to do. These are:

  • LIST_EXTEND
  • DICT_UPDATE @Sacul0457
  • SET_UPDATE @Sacul0457
  • DICT_MERGE @NekoAsakura
  • CALL_INTRINSIC_1 @Sacul0457
  • CALL_INTRINSIC_2 @KevinH15291

In addition, POP_ITER, END_FOR and END_SEND can be implemented as macro ops, using POP_TOP to gain the benefit of the the POP_TOP optimization.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Linked PRs
  • gh-145964
  • gh-145979
  • gh-146170
  • gh-146177
  • gh-146185
  • gh-146190
  • gh-146262
  • gh-146329
  • gh-146383
  • gh-148227
  • gh-148477

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

先閱讀後續 issue 134584,了解其中描述的轉換模式,並檢查列出的剩餘 uops:LIST_EXTEND、DICT_UPDATE、SET_UPDATE、DICT_MERGE、CALL_INTRINSIC_1 和 CALL_INTRINSIC_2。也要檢查 POP_ITER、END_FOR 和 END_SEND 的表示方式;完成意味著這些操作使用提議的堆疊清理方案,但連結的 PR 顯示這項工作已經在進行中。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
compilers, performance
Issue 類型
功能
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
25/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。