sqlite3 connections always create a reference cycle
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 35.9k
- PR 合併指標
- PR 指標待擷取
描述
Bug report
Bug description:
This is perhaps an annoyance rather than a bug, but it's nice to avoid creating reference cycles if possible. Practically, this means that the ResourceWarning from an sqlite connection object going out of scope fires from a random irrelevant line - where the cyclic GC happens to run - rather than predictably where the object goes out of scope.
The cycle is between the connection object and a functools _lru_cache_wrapper object, as can be seen like this:
import gc
import sqlite3
conn = sqlite3.connect(":memory:")
referrers = gc.get_referrers(conn)
for obj1 in gc.get_referents(conn):
for obj2 in referrers:
if obj1 is obj2:
print(obj1)
If I'm following the relevant C code correctly, it's similar to doing this in Python:
# In Connection.__init__
self.statement_cache = lru_cache(maxsize)(self)
# In Cursor get_statement_from_cache
self.connection.statement_cache(sql)
I believe the reference cycle could be avoided by doing something like this:
# A function (/staticmethod etc.) not bound to the Connection instance
def compile_stmt(wr_conn, sql):
conn = wr_conn()
assert conn is not None
return conn(sql)
# In Connection.__init__
self.statement_cache = lru_cache(maxsize)(compile_stmt)
# In Cursor get_statement_from_cache
wr_conn = weakref.ref(self.connection)
self.connection.statement_cache(wr_conn, sql)
Or functools.partial could be used to wrap the function so that the weakref is only created once. The significant bit is the connection's cache having only weakrefs back to the connection object. I'm not great at writing C code, but I think I can see that everything required for this is available as C functions.
Thanks!
CPython versions tested on:
3.14
Operating systems tested on:
Linux
Linked PRs
- gh-144383
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從報告中描述的進入點 sqlite3 Connection.init 和 Cursor get_statement_from_cache 開始,然後檢視相關的 PR gh-144383。當連線快取不再建立參照循環,且連線超出作用域時 ResourceWarning 的行為可預測,即表示完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python, sqlite
- 領域
- databases
- Issue 類型
- 缺陷
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 25/100