Issues in asyncio documentation section "A homemade asyncio.sleep"
未关闭
docs
topic-asyncio
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Documentation
Link to section:
https://docs.python.org/3/howto/a-conceptual-overview-of-asyncio.html#a-homemade-asyncio-sleep
From my perspective, there are two issues in this section:
- Creating a task for the sleep call in
main(await asyncio.create_task(async_sleep(3))) hides if the implementation actually cedes control to the event loop as desired or if it blocks it - an implementation usingtime.sleep(seconds)would also behave sane here. Therefore, I think it should be changed toawait async_sleep(3). - The implementation is said to mimick
asyncio.sleep(), which can make readers think that this could actually be a usable replacement that behaves similarly. However, in one crucial aspect it behaves the opposite way: It causes 100% CPU usage on one core due to the busy waiting approach, which is opposed to how a sleep should behave. Two options I see:
- Add something like: "Note: This implementation uses busy waiting and will consume 100% CPU on one core, unlike the real
asyncio.sleep(). This implementation is purely meant for educational purposes to demonstrate futures and event loop interaction." - Add a synchronous
time.sleep(0.001)or such right beforeawait YieldToEventLoop()(in both example implementations) and explain (trade-off, sub-optimal workaround, will cause undesired CPU usage but significantly less than without).
Linked PRs
- gh-143850
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。