python / python/cpython

test_ctx_mgr_rollback_if_commit_failed assumes outdated SQLite locking behavior

未關閉
#143,263 13 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

@picnixz 已經在處理了。

開始於 2026年1月2日。

tests topic-sqlite3 type-bug
主要語言
Python
星號
77.2k
分支
36k
PR 合併指標
PR 指標待擷取

描述

Bug report

Bug description:

It's possible this is user error or similar, but I'm observing the following when compiling Python3.14.

The test test_ctx_mgr_rollback_if_commit_failed in Lib/test/test_sqlite3/test_dbapi.py seems to fail with modern SQLite versions because it assumes that a read-only transaction plus a user-defined function will block concurrent writers. The current test encodes a stronger assumption than SQLite provides, making it brittle across SQLite versions.

With recent SQLite releases (e.g. 3.47+), this assumption seems to be no longer valid, causing the parent process to successfully write to the database and the child process to fail with: sqlite3.OperationalError: user-defined function raised exception

This results in a false-negative test failure. The test contains the following assertion in the child process:

assert "database is locked" in input()

However, modern SQLite allows the parent to acquire a write lock in this scenario, so the parent correctly sends "no error" instead.

This causes the assertion to fail even though SQLite and the context manager are behaving correctly.

The proposed fix is relax the assertion to accept both valid outcomes:

line = input()
assert "database is locked" in line or "no error" in line

This preserves the original intent of verifying correct rollback behavior while remaining compatible with modern SQLite locking semantics.


Environment
• SQLite: 3.47.0
• Python: 3.14-dev / 3.12+
• Platform: Amz Linux 2023 (aarch64, but not architecture-specific)
• Compiler: Clang20

CPython versions tested on:

3.14

Operating systems tested on:

Linux

Linked PRs
  • gh-143373
  • gh-146575

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。