python / python/cpython

shutil.copytree infinite recursion crash on Windows Directory Junctions (WinError 206)

未關閉
#142,155 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

OS-windows stdlib type-bug
主要語言
Python
星號
77.2k
分支
35.9k
PR 合併指標
PR 指標待擷取

描述

Bug report

Bug description:

Bug Description

On Windows, shutil.copytree fails to detect recursive cycles when processing Directory Junctions.

In Lib/shutil.py, the code explicitly forces traversal into Windows Junctions by treating them as standard directories (is_symlink is forced to False). However, there is no cycle detection mechanism (e.g., checking st_ino / nFileIndex) for these traversed directories.

If a Junction points to a parent directory, shutil.copytree enters an infinite recursion loop until it hits the OS path length limit, causing the process to crash with WinError 206 (Path too long) or WinError 1921.

Reproduction Steps

Run the following script on Windows:

import os
import shutil
import subprocess
import tempfile

def test_junction_crash():
    base_temp = tempfile.mkdtemp()
    src = os.path.join(base_temp, "Source")
    dst = os.path.join(base_temp, "Dest")
    junction = os.path.join(src, "Loop")
    
    try:
        os.makedirs(src)
        # Create a recursive Junction: Source/Loop -> Source
        subprocess.run(f'mklink /J "{junction}" "{src}"', shell=True, check=True)
        
        print("Starting copytree (expecting crash)...")
        shutil.copytree(src, dst)
        
    except Exception as e:
        print(e)

if __name__ == "__main__":
    test_junction_crash()

Actual Behavior

The script crashes with an unhandled shutil.Error wrapping a WinError 206, showing a deeply nested path.

Traceback:

Traceback (most recent call last):
  ...
  File "C:\...\lib\shutil.py", line 559, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
  File "C:\...\lib\shutil.py", line 513, in _copytree
    raise Error(errors)
shutil.Error: [('...\\Source\\Infinite_Loop\\Infinite_Loop\\Infinite_Loop...', '...', "[WinError 206] The filename or extension is too long")]

Expected Behavior

shutil.copytree should detect that the Junction points to a directory that has already been visited (cycle detection) and either raise a specific RecursionError / FileExistsError or skip it.

System Details

OS: Windows 10/11
Python Version: Verified on main branch

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs
  • gh-142156

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

閱讀 Lib/shutil.py 中 copytree 附近的程式碼,並使用 issue 中的腳本在 Windows 上重現回報的 junction cycle。完成標準是處理遞迴 junctions 時不會達到 path-length limit,且行為與所選的錯誤或跳過結果一致;gh-142156 已經連結到此 issue。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
operating-systems
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
25/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。