python / python/cpython

heap-buffer-overflow in pycore_interpframe.h _PyFrame_Initialize

Open
#140,802 15 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

interpreter-core type-crash
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

Crash report

What happened?
import sys
import asyncio

class JumpTracer:
    def __init__(self, func, jump_to):
        self.code = func.__code__
        self.jump_to = jump_to
        self.first_line = None

    def trace(self, frame, event, arg):
        if self.first_line is None and event == 'line' and frame.f_code is self.code:
            self.first_line = frame.f_lineno - 1
            try:
                frame.f_lineno = self.first_line - self.jump_to
            except TypeError:
                frame.f_lineno = self.jump_to
        return self.trace

async def target():
    # Keep a couple of lines so the tracer has places to land.
    x = 0
    x += 1
    return x

if __name__ == "__main__":
    tracer = JumpTracer(target, jump_to=1)
    sys.settrace(tracer.trace)
    asyncio.run(target())
=================================================================
==1675806==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x510000044e00 at pc 0x61c306b4803a bp 0x7ffebaccfa40 sp 0x7ffebaccfa30
WRITE of size 8 at 0x510000044e00 thread T0
    #0 0x61c306b48039 in _PyFrame_Initialize ../Include/internal/pycore_interpframe.h:154
    #1 0x61c306b48039 in _PyEvalFramePushAndInit ../Python/ceval.c:1874
    #2 0x61c306b5262f in _PyEval_Vector ../Python/ceval.c:1995
    #3 0x61c3067d3af3 in _PyObject_VectorcallTstate ../Include/internal/pycore_call.h:169
    #4 0x61c3067d3af3 in PyObject_VectorcallMethod ../Objects/call.c:859
    #5 0x61c306d8d296 in call_soon ../Modules/_asynciomodule.c:388
    #6 0x61c306d97254 in future_schedule_callbacks ../Modules/_asynciomodule.c:455
    #7 0x61c306d9bf0a in future_set_result ../Modules/_asynciomodule.c:653
    #8 0x61c306d9bf0a in task_step_impl ../Modules/_asynciomodule.c:3147
    #9 0x61c306da0377 in task_step ../Modules/_asynciomodule.c:3463
    #10 0x61c306da0377 in TaskStepMethWrapper_call ../Modules/_asynciomodule.c:2120
    #11 0x61c3067cfc5d in _PyObject_MakeTpCall ../Objects/call.c:242
    #12 0x61c306b98e24 in _PyObject_VectorcallTstate ../Include/internal/pycore_call.h:167
    #13 0x61c306b98e24 in context_run ../Python/context.c:728
    #14 0x61c3067d678e in _PyVectorcall_Call ../Objects/call.c:273
    #15 0x61c3067d678e in _PyObject_Call ../Objects/call.c:348
    #16 0x61c3067d678e in PyObject_Call ../Objects/call.c:373
    #17 0x61c306675e9c in _PyEval_EvalFrameDefault ../Python/generated_cases.c.h:2616
    #18 0x61c306b51fb6 in _PyEval_EvalFrame ../Include/internal/pycore_ceval.h:121
    #19 0x61c306b51fb6 in _PyEval_Vector ../Python/ceval.c:2005
    #20 0x61c306b51fb6 in PyEval_EvalCode ../Python/ceval.c:888
    #21 0x61c306d103fe in run_eval_code_obj ../Python/pythonrun.c:1365
    #22 0x61c306d103fe in run_mod ../Python/pythonrun.c:1459
    #23 0x61c306d150a7 in pyrun_file ../Python/pythonrun.c:1293
    #24 0x61c306d150a7 in _PyRun_SimpleFileObject ../Python/pythonrun.c:521
    #25 0x61c306d15bcc in _PyRun_AnyFileObject ../Python/pythonrun.c:81
    #26 0x61c306d883cc in pymain_run_file_obj ../Modules/main.c:410
    #27 0x61c306d883cc in pymain_run_file ../Modules/main.c:429
    #28 0x61c306d883cc in pymain_run_python ../Modules/main.c:691
    #29 0x61c306d89cae in Py_RunMain ../Modules/main.c:772
    #30 0x61c306d89cae in pymain_main ../Modules/main.c:802
    #31 0x61c306d89cae in Py_BytesMain ../Modules/main.c:826
    #32 0x7ee30b1ea1c9  (/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9) (BuildId: 282c2c16e7b6600b0b22ea0c99010d2795752b5f)
    #33 0x7ee30b1ea28a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2a28a) (BuildId: 282c2c16e7b6600b0b22ea0c99010d2795752b5f)

0x510000044e00 is located 0 bytes after 192-byte region [0x510000044d40,0x510000044e00)
allocated by thread T0 here:
    #0 0x7ee30b5b89c7 in malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:69
    #1 0x61c306be8c1e in _PyObject_MallocWithType ../Include/internal/pycore_object_alloc.h:46
    #2 0x61c306be8c1e in gc_alloc ../Python/gc.c:2343
    #3 0x61c306be8c1e in _PyObject_GC_NewVar ../Python/gc.c:2385
    #4 0x61c306822e1c in make_gen ../Objects/genobject.c:927
    #5 0x61c30682d932 in _Py_MakeCoro ../Objects/genobject.c:970
    #6 0x61c30667b85d in _PyEval_EvalFrameDefault ../Python/generated_cases.c.h:10356
    #7 0x61c306b51fb6 in _PyEval_EvalFrame ../Include/internal/pycore_ceval.h:121
    #8 0x61c306b51fb6 in _PyEval_Vector ../Python/ceval.c:2005
    #9 0x61c306b51fb6 in PyEval_EvalCode ../Python/ceval.c:888
    #10 0x61c306d103fe in run_eval_code_obj ../Python/pythonrun.c:1365
    #11 0x61c306d103fe in run_mod ../Python/pythonrun.c:1459
    #12 0x61c306d150a7 in pyrun_file ../Python/pythonrun.c:1293
    #13 0x61c306d150a7 in _PyRun_SimpleFileObject ../Python/pythonrun.c:521
    #14 0x61c306d15bcc in _PyRun_AnyFileObject ../Python/pythonrun.c:81
    #15 0x61c306d883cc in pymain_run_file_obj ../Modules/main.c:410
    #16 0x61c306d883cc in pymain_run_file ../Modules/main.c:429
    #17 0x61c306d883cc in pymain_run_python ../Modules/main.c:691
    #18 0x61c306d89cae in Py_RunMain ../Modules/main.c:772
    #19 0x61c306d89cae in pymain_main ../Modules/main.c:802
    #20 0x61c306d89cae in Py_BytesMain ../Modules/main.c:826
    #21 0x7ee30b1ea1c9  (/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9) (BuildId: 282c2c16e7b6600b0b22ea0c99010d2795752b5f)
    #22 0x7ee30b1ea28a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2a28a) (BuildId: 282c2c16e7b6600b0b22ea0c99010d2795752b5f)

SUMMARY: AddressSanitizer: heap-buffer-overflow ../Include/internal/pycore_interpframe.h:154 in _PyFrame_Initialize
Shadow bytes around the buggy address:
  0x510000044b80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x510000044c00: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
  0x510000044c80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 05
  0x510000044d00: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
  0x510000044d80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x510000044e00:[fa]fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x510000044e80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x510000044f00: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x510000044f80: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
  0x510000045000: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x510000045080: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==1675806==ABORTING
CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Output from running 'python -VV' on the command line:

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the supplied asyncio and sys.settrace reproducer under an AddressSanitizer build. Inspect _PyFrame_Initialize in Include/internal/pycore_interpframe.h and its callers in Python/ceval.c, especially _PyEvalFramePushAndInit. Done means the reproducer no longer reports a heap-buffer-overflow on the CPython main branch.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.