python / python/cpython

Consider removing the thread and future handling in asyncio REPL

未关闭
#140,355 5 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@ambv 已经在做这个了。

开始于 2025年10月21日。

stdlib topic-asyncio type-feature
主要语言
Python
星标
77.2k
派生
35.9k
PR 合并指标
PR 指标待抓取

描述

Bug report

Bug description:

In the current asyncio REPL, the event loop runs in the main thread, while the interactive console operates in a separate thread as both are running blocking loops. This leads to issues with console input handling, as noted in issue gh-140163 and gh-138827.

https://github.com/python/cpython/blob/d86ad870cc112d4bd36165398368826746555730/Lib/asyncio/__main__.py#L226-L240

While this is a MacOS-specific issue, it reveals a defect of the existing implementation. Specifically, the REPL can never receives Ctrl-C event and set the readline status properly, as it does normally. As the above code shows, the outer-most loop catches the KeyboardInterrupt and sets a flag, then tells the REPL to respond. However, the console loop never stops when this happens, because you can't actually interrupt input() from outside the thread, making it unable to respond to outer events.

So I rethink of the necessity of separate threads and also refer to the implementation of IPython. In a REPL, each cell is executed, and the result is awaited. There doesn't seem to be a need for a concurrent setup. A simple loop.run_until_complete() will do, as IPython does. At the same time, this can also greatly simplify the existing code.

However, I know I could be very wrong. So please correct me.

DPO link: https://discuss.python.org/t/consider-removing-the-thread-and-future-handling-in-asyncio-repl/104457

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
  • gh-140356

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。