python / python/cpython

Add tests on basic `PyStackRef` functions

未关闭
#139,716 0 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@efimov-mikhail 已经在做这个了。

开始于 2025年10月16日。

extension-modules tests type-feature
主要语言
Python
星标
77.2k
派生
35.9k
PR 合并指标
PR 指标待抓取

描述

Feature or enhancement

Proposal:

Definitions of basic PyStackRef manipulation functions aren't so easy.
There are a lot of them, they have connections to each other and we have 3 variants of them now (GIL, no-GIL, PyStackRef debug).

It's easy to forget something when provide some change to them.
In fact, there is one of such issues for PyStackRef debug build: https://github.com/python/cpython/issues/135125

I propose to add tests that ensure all basic PyStackRef functions are correct in combination.

I've already have a PR.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs
  • gh-139717
  • gh-141675
  • gh-143024

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。