The C analyzer seems to fail when `--disable-gil` is set
Nessuno ha ancora preso questa issue.
- Lingua principale
- Python
- Stelle
- 77.2k
- Fork
- 35.9k
- Metriche di merge delle PR
- Metriche PR in attesa
Descrizione
Bug report
Bug description:
When running the C analyzer's check-c-globals script locally, I noticed this failure on gc_free_threading.c:
$ python3.13 Tools/c-analyzer/check-c-globals.py Python/gc_free_threading.c
analyzing files...
.# requested file: </home/peter/develop/cpython/Python/gc_free_threading.c>
-------------------------
Non-constant global variables are generally not supported
in the CPython repo. We use a tool to analyze the C code
and report if any unsupported globals are found. The tool
may be run manually with:
./python Tools/c-analyzer/check-c-globals.py --format summary [FILE]
Occasionally the tool is unable to parse updated code.
If this happens then add the file to the "EXCLUDED" list
in Tools/c-analyzer/cpython/_parser.py and create a new
issue for fixing the tool (and CC ericsnowcurrently
on the issue).
If the tool reports an unsupported global variable and
it is actually const (and thus supported) then first try
fixing the declaration appropriately in the code. If that
doesn't work then add the variable to the "should be const"
section of Tools/c-analyzer/cpython/ignored.tsv.
If the tool otherwise reports an unsupported global variable
then first try to make it non-global, possibly adding to
PyInterpreterState (for core code) or module state (for
extension modules). In an emergency, you can add the
variable to Tools/c-analyzer/cpython/globals-to-fix.tsv
to get CI passing, but doing so should be avoided. If
this course it taken, be sure to create an issue for
eliminating the global (and CC ericsnowcurrently).
ERROR: unmatched text (/home/peter/develop/cpython/Python/gc_free_threading.c starting at line 524):
extern int (*__Static_assert_function (void)) [!!sizeof ( struct inline-1 )] ; extern int (*__Static_assert_function (void)) [!!sizeof (struct { int __error_if_negative: ( 16 < 256 && 8 < 16 && 8 > 0 ) ? 2 : -1; })] ; typedef struct { PyObject **start; PyObject **end; } gc_span_t; typedef struct { Py_ssize_t size; Py_ssize_t capacity; gc_span_t *stack; } gc_span_stack_t; typedef struct { unsigned int in; unsigned int out; _PyObjectStack stack; gc_span_stack_t spans; PyObject *buffer[256]; _Bool ...
This only comes up when ./configure --disable-gil is used beforehand (which is a little odd, considering a release build of Python is being used, not the local compiled version), so it doesn't show up in CI.
cc @ericsnowcurrently
CPython versions tested on:
CPython main branch, 3.14
Operating systems tested on:
Linux
Linked PRs
- gh-156969
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia con Tools/c-analyzer/check-c-globals.py e riproduci il fallimento su Python/gc_free_threading.c usando il comando indicato nel report. Leggi le indicazioni relative al parser in Tools/c-analyzer/cpython/_parser.py e controlla la PR collegata gh-156969. Il lavoro è completato quando l’analizzatore elabora questo file senza il fallimento relativo al testo non corrispondente segnalato.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- c, python
- Ambito
- tooling
- Tipo di issue
- Bug
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 25/100