python / python/cpython

HTMLParser differences from the HTML5 specification

Offen
#135,661 14 Kommentare 4 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@serhiy-storchaka arbeitet bereits daran.

Seit 18.6.2025.

3.10 3.11 3.15 3.9 (EOL) stdlib type-bug type-security
Vorherrschende Sprache
Python
Sterne
77.2k
Forks
35.9k
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

Bug report

Originally, the definition of the HTML format was not formally strict. It was similar to SGML and XML, but with a lot of looseness. HTMLParser tried its best to parse anything that looked like HTML. But after creation of HTML5, its specification defines the parsing rules for HTML documents, whether they are syntactically correct or not. It is important to follow these rules, for security reasons.

The current HTMLParser mainly follows the HTML5 specification, but there are a number of differences:

  1. --!> should end the comment. #135664
  2. -- > should not end the comment. #135664
  3. <--> and <---> should be abnormally ended empty comments. #135664
  4. ] ]> and ]] > should not end the CDATA section. #135665
  5. 🤕 CDATA handling should depend on the current node. This is important, because the ending condition are different for the CDATA section and the bogus comment (]]> and >).
  6. ✅ Whitespaces should not be acceptable between </ and the tag name. E.g. </ script> should not end the script section. #135930
  7. ✅ Vertical tabulation (\v) and non-ASCII whitespaces should not be recognized as whitespaces. The only whitespaces are \t\n\r\f . #135930
  8. ✅ Null character (U+0000) should not end the tag name. #135930
  9. Null character (U+0000), surrogate characters and many other special characters should be replaced by \xfffd. I think we can leave this, because it is easy to do in pre-processing or post-processing, and they usually do not cause issues in Python.
  10. ✅ End tag can have attributes and slashes after tag name. It can not end after the first >. E.g. </script/foo=">"/>. #135930
  11. ✅ Case-insensitive matching should only transform ASCII letters. E.g. </script> does not match </ſcript>, and LINK does not match LINK (the last letter is U+212A). #135930
  12. ✅ There may be multiple slashes and whitespaces between the last attribute and closing > in both start and end tags. E.g. <a foo=bar/ //>. #135930
  13. ✅ There should only be one = separator between attribute name and value. E.g. <a foo==bar> should have attribute "foo" with value "=bar". #135930
  14. No whitespace should be acceptable between the = separator and attribute name and value. E.g. <a foo =bar> should have two attributes "foo" and "=bar", both with value None; <a foo= bar> should have two attributes: "foo" with value "" and "bar" with value None.

This can cause security issues for some programs. If the program uses HTMLParser to check the HTML input for dangerous code, it can miss some code. For example, "<!----!><script>...</script><!---->" is parsed by browsers as a script block surrounded by two comments, but the current HTMLParser parses it as a single comment.

Linked PRs
  • gh-135664
  • gh-135665
  • gh-135930
  • gh-136255
  • gh-136256
  • gh-136268
  • gh-136291
  • gh-136292
  • gh-136293
  • gh-136908
  • gh-136918
  • gh-136919
  • gh-136920
  • gh-136921
  • gh-136922
  • gh-136927
  • gh-137772
  • gh-137773
  • gh-137774
  • gh-137873
  • gh-137875
  • gh-139659
  • gh-139660
  • gh-139661
  • gh-153007
  • gh-153024
  • gh-153025
  • gh-153026

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.