Pickle `FLOAT` opcode inconsistency with whitespace
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 35.9k
- PR merge metrics
- PR metrics pending
Description
Bug report
Bug description:
A lot of Python code tolerates leading and trailing whitespace in string-to-number conversions. However, in the FLOAT opcode of pickle, the Python implementation can tolerate leading/trailing whitespace, while the C implementation throws an error and can't convert it. Note that the INT opcode can gracefully handle leading/trailing whitespace (in both Python and C).
Payloads:
payload: b'F 5\n.'
pickle: 5.0
_pickle.c: FAILURE could not convert string to float: ' 5
'
pickletools:
0: F FLOAT 5.0
4: . STOP
highest protocol among opcodes = 0
payload: b'F5 \n.'
pickle: 5.0
_pickle.c: FAILURE could not convert string to float
pickletools:
0: F FLOAT 5.0
4: . STOP
highest protocol among opcodes = 0
payload: b'I 5 \n.'
pickle: 5
_pickle.c: 5
pickletools:
0: I INT 5
5: . STOP
highest protocol among opcodes = 0
CPython versions tested on:
3.13
Operating systems tested on:
Linux
Linked PRs
- gh-135619
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Python and C implementations of pickle's FLOAT opcode and compare their handling of the supplied payloads. Run the examples on Python 3.13, then verify that leading and trailing whitespace is handled consistently in both implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100