python / python/cpython

Makefile always regenerates `build-details.json`

Open
#131,556 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

build type-bug
Dominant language
Python
Stars
77.2k
Forks
35.9k
PR merge metrics
PR metrics pending

Description

The Makefile target that generates build-details.json has an incorrect target so it's re-run for every action. The generated file is in:

`cat pybuilddir.txt`/build-details.json

For example, on my machine that evaluates to:

build/lib.linux-x86_64-3.14/build-details.json

https://github.com/python/cpython/blob/61317074d450f72fa121ceb1c7b0c52698a71106/Makefile.pre.in#L939-L940

Linked PRs
  • gh-131558
  • gh-131761

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at lines 939-940 of Makefile.pre.in and inspect how the target path is derived from pybuilddir.txt. Reproduce a build action that regenerates build-details.json unnecessarily, then verify that repeated actions no longer rerun that target.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.