python / python/cpython

Dictionary max modifications threshold too low for JIT

Open
#131,194 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

interpreter-core performance topic-JIT
Dominant language
Python
Stars
77.2k
Forks
36k
PR merge metrics
PR metrics pending

Description

If you just run something like import time, the globals to constants promoter fails. This seems counterproductive.

We should up the max number of dictionary modifications allowed to something in the hundreds range, or whatever a big app might suggest.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with import time, then trace the globals-to-constants promoter to find where the maximum dictionary-modification threshold is defined. Determine a suitable higher limit and verify that the promoter no longer fails for this import while existing JIT tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.