Various data races in subinterpreter tests under TSAN
未关闭
还没有人认领这个 Issue。
interpreter-core
topic-subinterpreters
type-bug
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Bug report
Thread sanitizer reports a number of data races when running subinterpreter tests
InterpreterPoolMixin (test_concurrent_futures)
-
run_eval_code_obj: see https://github.com/python/cpython/issues/128130 -
posixmodule_execmodifies globalswaitid_result_descandstat_result_desc -
_PyBuiltins_AddExceptions: modifies globalsPyExc_EnvironmentError, etc. https://github.com/python/cpython/blob/49bd47d5f14993d37b97aa2bbf257f5df16b96a9/Objects/exceptions.c#L4354-L4355 -
_PyInterpreterState_FinalizeAllocatedBlocks: modifies _PyRuntime variable _PyInterpreterState_FinalizeAllocatedBlocks -
_globals_fini+clear_interpreter: data race on_globals.module_count(the read inclear_interpreterhappens outside of a lock) -
init_static_exctypes: modifies globals_PyExc_InterpreterError, etc. -
_structmodule_exec: data race reported onptr->unpack = native->unpack
I think for now it would make sense to skip the InterpreterPoolMixin tests when running with TSAN.
test__interpchannels
-
find_name_in_mroand_waiting_release: I don't understand this one, but it happens duringtest_send_recv_different_interpreters_and_threads
test__interpreters and test_interpreters
-
type_ready_set_new: https://github.com/python/cpython/blob/7b2e01bb555359913939d7ff168363f1760d3f8e/Objects/typeobject.c#L8509 -
type_ready: (see https://github.com/python/cpython/issues/129817) - File descriptor race in
test_api.LowLevelTests.test_is_runningandtest_running:close()concurrent withread()on the same file descriptor. -
managed_static_type_state_initintest.test_interpreters.test_stress.StressTests.test_create_many_threaded: data race on the non-atomic read ofinterp_count. - pegen
memo_statisticsmutex is currently only used in free threading build (seen in test_create_many_threaded) - version tags on static types:
NEXT_GLOBAL_VERSION_TAG,type->tp_versions_used, andtp->tp_version_tagmodifications are not thread-safe (seen in test_create_many_threaded)
test_capi.test_misc.assign_version_tag
- race on
NEXT_GLOBAL_VERSION_TAGinassign_version_tag(see above)
Linked PRs
- gh-129826
- gh-129829
- gh-135794
- gh-136266
- gh-143446
- gh-143530
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
先从 test_concurrent_futures、test__interpchannels 和 test__interpreters 中尚未检查的竞态开始,然后阅读 Modules/posixmodule.c、Objects/typeobject.c、Modules/_interpchannelsmodule.c 和 Modules/_struct.c 中链接的位置。在 TSAN 下运行受影响的子解释器测试;当每个已报告的竞态都有经过审查的解决方案或已记录的处置,并且已考虑链接的 PR 时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- c, python
- 领域
- backend, testing-qa
- Issue 类型
- 缺陷
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 停滞
- 描述清晰度
- 需要澄清
- 新手友好度
- 20/100