python / python/cpython

Remove comments from `find_assignment_target` result

未关闭
#128,742 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

interpreter-core type-bug
主要语言
Python
星标
77.2k
派生
35.9k
PR 合并指标
PR 指标待抓取

描述

Bug report

Bug description:

Tools/cases_generator/tier1_generator.py fails if you place comment before PyStackRef_FromPyObjectNew assignment. Example reproducer (bytecodes.c:291-293):

pure inst(LOAD_CONST, (-- value)) {
     // comment
    value = PyStackRef_FromPyObjectNew(GETITEM(FRAME_CO_CONSTS, oparg));
}
/python.exe Tools/cases_generator/tier1_generator.py

Traceback (most recent call last):
  File "/Users/yyanchii/Desktop/cpython/Tools/cases_generator/tier1_generator.py", line 221, in <module>
    data = analyze_files(args.input)
  File "/Users/yyanchii/Desktop/cpython/Tools/cases_generator/analyzer.py", line 1184, in analyze_files
    return analyze_forest(parser.parse_files(filenames))
  File "/Users/yyanchii/Desktop/cpython/Tools/cases_generator/analyzer.py", line 1133, in analyze_forest
    desugar_inst(node, instructions, uops)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/yyanchii/Desktop/cpython/Tools/cases_generator/analyzer.py", line 947, in desugar_inst
    uop = make_uop("_" + inst.name, inst, op_inputs, uops)
  File "/Users/yyanchii/Desktop/cpython/Tools/cases_generator/analyzer.py", line 854, in make_uop
    deferred_refs=analyze_deferred_refs(op),
                  ~~~~~~~~~~~~~~~~~~~~~^^^^
  File "/Users/yyanchii/Desktop/cpython/Tools/cases_generator/analyzer.py", line 458, in analyze_deferred_refs
    raise analysis_error(
        "PyStackRef_FromPyObjectNew() must be assigned to an output", tkn
    )
  File "/Users/yyanchii/Desktop/cpython/Python/bytecodes.c", line 293
    
    ^
SyntaxError: PyStackRef_FromPyObjectNew() must be assigned to an output

Problem is in:
https://github.com/python/cpython/blob/22a442181d5f1ac496dac08e24fd852de404882f/Tools/cases_generator/analyzer.py#L457-L460

as lhs may contain leading comments which are ignored during extraction.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, macOS, Windows

Linked PRs
  • gh-128743

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 Tools/cases_generator/analyzer.py 中 457-460 行附近的 analyze_deferred_refs 开始,issue 在此处指出 lhs 中的前置注释是原因。使用 Tools/cases_generator/tier1_generator.py 和 bytecodes.c 示例复现;当赋值前的注释不再触发 PyStackRef_FromPyObjectNew() 错误时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
tooling
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。