Incorrect SyntaxError attributes when raised by `compile`
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Bug report
Bug description:
This is probably a problem with compile, and I will demonstrate it through ast.parse. Consider the following code in a file f.py.
import ast
code = "x y"
ast.parse(code, filename='f.py')
This correctly raises a SyntaxError with lineno = 1 and offset = 3 since the error is at the beginning of y in the code. However, the traceback points into the file f.py itself, instead of the string code. Notice that it points to the third column of the first line of f.py.
File "f.py", line 1
import ast
^
SyntaxError: invalid syntax
This does not happen for any other string given as filename to ast.parse. In general, the traceback seems to point with the "correct" lineno and offset to the code in the file itself instead of code given to ast.parse. However, the problem is slightly more nuanced. If the offset in the string given to ast.parse is more than the length of the corresponding line in f.py, the offset attribute of the SyntaxError raised is incorrectly set to the length of the corresponding line in f.py plus two. Consider the following code in f.py.
import ast
code = " x y"
ast.parse(code, filename='f.py')
This raises the following exception.
File "f.py", line 1
import ast
^
IndentationError: unexpected indent
On closer inspection, it turns out that the offset of the exception raised is 12 (note that the length of "import ast" is 10) instead of the correct 37 which is observed when filename is set to anything other than f.py. However, something more interesting happens when the number of lines in the code string is more than the number of lines in the file f.py.
import ast
code = "\n\n\n\nx y"
ast.parse(code, filename='f.py')
The problem goes away!
File "f.py", line 5
x y
^
SyntaxError: invalid syntax
We even see the correct offset.
CPython versions tested on:
3.11, 3.12, 3.13
Operating systems tested on:
Linux
(Edit) Incorrect text attribute
There is something more going on here. The following issue can be seen in 3.11 and 3.12 but not in 3.13. Consider the following f.py.
import ast
with open('temp.py') as f:
code = f.read()
ast.parse(code, filename='temp.py')
temp.py is as follows.
""" """; x """ """; foobar
This leads to the following traceback.
File "temp.py", line 1
foobar
^
SyntaxError: invalid syntax
Besides the fact that the offset is incorrectly set to 8 (instead of 840), the text is incorrectly set to foobar (on 3.13, the entire file contents of temp.py are present in text). This problem goes away if filename is set to anything else. The problem also goes away if the contents of temp.py are shorter!
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
首先使用 ast.parse 和 compile 重現這些範例,比較 filename 與來源檔案相符和不相符時的 SyntaxError 屬性。追蹤檔名相符時 traceback、offset 和 text 的填入方式。當在所示案例中,lineno、offset、text 和 traceback 始終一致地描述已解析的字串,並且這些範例具有回歸測試涵蓋時,即可視為完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- compilers
- Issue 類型
- 缺陷
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 38/100