Circular import error for `threading` when using `importlib.util.LazyLoader` with a custom finder
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 35.9k
- PR 合併指標
- PR 指標待擷取
描述
Bug report
Bug description:
When using a custom finder (on sys.meta_path) that wraps a module spec's loader with importlib.util.LazyLoader, the threading import within importlib.util.LazyLoader.exec_module is attempted with the custom finder, causing a circular import error.
Not sure if this is more of a feature request than a bug report, but the behavior was certainly surprising at first glance. Hopefully there's a way to better support this use case from within the stdlib without too much burden. Otherwise, users of LazyLoader in this manner would be forced to either a) maintain an exclusion list of modules that their finder ignores, potentially including all of threading's dependencies or b) always import threading before using such finders, which shouldn't be necessary, especially if threading isn't directly used by the user code.
Reproducer
import importlib.util
import sys
class LazyFinder:
"""A module spec finder that wraps a spec's loader, if it exists, with LazyLoader."""
@classmethod
def find_spec(cls, fullname: str, path=None, target=None, /):
for finder in sys.meta_path:
if finder is not cls:
spec = finder.find_spec(fullname, path, target)
if spec is not None:
break
else:
raise ModuleNotFoundError(...)
if spec.loader is not None:
spec.loader = importlib.util.LazyLoader(spec.loader)
return spec
class LazyFinderContext:
"""Temporarily "lazify" some types of import statements in the runtime context."""
def __enter__(self):
if LazyFinder not in sys.meta_path:
sys.meta_path.insert(0, LazyFinder)
def __exit__(self, *exc_info):
try:
sys.meta_path.remove(LazyFinder)
except ValueError:
pass
with LazyFinderContext():
import inspect
Expected Output
No error.
Actual Output
> python scratch.py
Traceback (most recent call last):
File "/home/thanos/projects/personal/pycc/scratch.py", line 40, in <module>
import inspect
File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib.util>", line 257, in exec_module
File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib.util>", line 267, in exec_module
AttributeError: partially initialized module 'threading' has no attribute 'RLock' (most likely due to a circular import)
Commentary
This is technically caused by this code:
https://github.com/python/cpython/blob/9dabace39d118ec7a204b6970f8a3f475a11522c/Lib/importlib/util.py#L256-L260
However, it is based on the fair assumptions that LazyLoader a) isn't critical to CPython startup, and b) won't be used in a circular fashion with a custom finder. However, there are use cases for such a finder (e.g. https://github.com/scientific-python/lazy-loader/pull/121#issuecomment-2457961532, one place this issue was discovered). While finders utilizing the lazy loader could work around this with an exclusion list of modules (e.g. mercurial's lazy loader does), I think users would find using LazyLoader easier with the finder-related import hooks if that wasn't necessary.
Based on the commit history, a top-level import for threading breaks gevent, so I'd rather not repeat that. I'm not very familiar with gevent, but if using _thread.RLock is fine in importlib._bootstrap for the module locks, then maybe that could be used in importlib.util as well?
EDIT: Updated code snippet to be consistent with output; accidentally used a different import while testing. Still, same result.
CPython versions tested on:
3.12, 3.13
Operating systems tested on:
Linux, Windows
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
首先,使用自訂 finder 執行提供的重現程式,並檢查 Lib/importlib/util.py,尤其是 LazyLoader.exec_module 以及 256-260 附近連結的行。在 Python 3.12 和 3.13 上比較行為;當重現程式能在維持所述啟動限制的同時匯入 inspect,且不出現循環匯入導致的 AttributeError 時,即表示完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- backend, tooling
- Issue 類型
- 缺陷
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100