SSLSocket.getpeercert returns none if cert isn't valid
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 35.9k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Bug report
Bug description:
It's possible I'm misunderstanding, but it seems the documentation around SSLSocket.getpeercert is incorrect and/or the function is bugged. This was run on Fedora 40 with python 3.12.5. I'm trying to bypass DNS and pull the SSL cert straight from an IP for a specific set of Hosts.
the docs I'm referencing: https://docs.python.org/3/library/ssl.html#ssl.SSLSocket.getpeercert
Site and HostIP are variables representing a site URL and a Apache server's direct IP address. This is inside a function call.
the code:
#empty cert info dict
SiteCertInfo = {}
#create SSL context and socket
#this overrides "DNS" so we can pull the SSL cert as it is on the server
sslContext = ssl.create_default_context()
sslSock = socket.socket()
sslConn = sslContext.wrap_socket(sslSock, server_hostname=Site)
#try the connection
try:
sslConn.connect((HostIp, 443))
#ssl cert can't be verified / doesn't match
except ssl.SSLCertVerificationError as ex:
#show error reasons
print(Site + " site SSL did not verify. reason: " + ex.verify_message, file=sys.stderr)
#continue
pass
#pull the cert from the connection
sslCert = sslConn.getpeercert()
The error:
sslCert = sslConn.getpeercert()
^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.12/ssl.py", line 1129, in getpeercert
return self._sslobj.getpeercert(binary_form)
^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'getpeercert'
The issue:
The documentation states "for a client SSL socket, the server will always provide a certificate, regardless of whether validation was required;" I'm reading that as my python "client" connecting to the remote server should always get a cert even if it fails validation.
However, if the certificate is expired I'm catching the error and continuing on via the pass call. The sslConn.getpeercert() call fails as sslConn is None. If I don't catch the error then it just fails as normal.
If I try and by-pass validation by doing:
sslContext = ssl.SSLContext(protocol = ssl.PROTOCOL_TLS_CLIENT)
sslContext.check_hostname = False
sslContext.verify_mode = ssl.CERT_NONE
sslContext.set_default_verify_paths()
This just fails and pulls a "empty" dict for sslCert. If I set verify_mode back to CERT_REQUIRED I'm back to square one.
So, there doesn't seem to be a way to "catch" the validation error, but still continue to load the cert if the cert is expired or to disable validation via CERT_NONE and still pull the cert data and manually "validate" it.
CPython versions tested on:
3.12
Operating systems tested on:
Linux
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con el comportamiento documentado de ssl.SSLSocket.getpeercert y la configuración de verificación de SSLContext; después, reproduce el flujo de conexión informado usando un certificado caducado y CERT_NONE. Compara el estado del socket después de SSLCertVerificationError con el resultado de getpeercert(binary_form=True). Se considera terminado cuando se haya establecido si el comportamiento es un error de implementación o un problema de documentación y se haya añadido la prueba de regresión correspondiente o una aclaración en la documentación.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- networking, security
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100