concurrent.futures.Future.add_done_callback: calling thread description error.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- PR merge metrics
- PR metrics pending
Description
asyncio.run_coroutine_threadsafe will return a concurrent.futures.Future.
And according to its doc concurrent.futures.Future.add_done_callback() :
Added callables are called in the order that they were added and are always ** called in a thread belonging to the process that added them. **
But acually, the callback is called in where Future.set_result() is called according to its source.
Linked PRs
- gh-122678
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the concurrent.futures.Future.add_done_callback() documentation and the behavior reached through asyncio.run_coroutine_threadsafe; compare the wording with the Future.set_result() source path. Done means the documentation accurately describes the thread in which callbacks run, with the existing linked PR considered before making changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100