python / python/cpython

New REPL will exit the interpreter due to errors from substituting builtins.__import__

Aperta
#122,533 5 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

3.13 3.14 stdlib topic-repl type-bug
Lingua principale
Python
Stelle
77.2k
Fork
35.9k
Metriche di merge delle PR
Metriche PR in attesa

Descrizione

Bug report

Bug description:

It's possible to make the new REPL exit the interpreter by replacing builtins.__import__ with a function that takes the wrong number of arguments or returns an invalid object. The basic REPL still works in these cases, even if imports don't. This happens in Linux and Windows with main.

>>> import builtins
>>> builtins.__import__ = lambda: None
>>> Exception ignored in the internal traceback machinery:
TypeError: <lambda>() takes 0 positional arguments but 5 were given
Traceback (most recent call last):
  File "/home/danzin/projects/cpython/Lib/runpy.py", line 198, in _run_module_as_main
  File "/home/danzin/projects/cpython/Lib/runpy.py", line 88, in _run_code
  File "/home/danzin/projects/cpython/Lib/_pyrepl/__main__.py", line 6, in <module>
  File "/home/danzin/projects/cpython/Lib/_pyrepl/main.py", line 59, in interactive_console
  File "/home/danzin/projects/cpython/Lib/_pyrepl/simple_interact.py", line 147, in run_multiline_interactive_console
  File "/home/danzin/projects/cpython/Lib/_pyrepl/readline.py", line 385, in multiline_input
  File "/home/danzin/projects/cpython/Lib/_pyrepl/reader.py", line 773, in readline
  File "/home/danzin/projects/cpython/Lib/_pyrepl/reader.py", line 722, in handle1
  File "/home/danzin/projects/cpython/Lib/_pyrepl/unix_console.py", line 549, in input_hook
TypeError: <lambda>() takes 0 positional arguments but 5 were given
Python 3.14.0a0 (heads/main:9187484dd97, Jul 29 2024, 09:25:22) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import builtins
>>> builtins.__import__ = lambda x, y, z, a, b: None
>>> Exception ignored in the internal traceback machinery:
Traceback (most recent call last):
  File "/home/danzin/projects/cpython/Lib/traceback.py", line 139, in _print_exception_bltin
    return print_exception(exc, limit=BUILTIN_EXCEPTION_LIMIT, file=file, colorize=colorize)
  File "/home/danzin/projects/cpython/Lib/traceback.py", line 129, in print_exception
    te = TracebackException(type(value), value, tb, limit=limit, compact=True)
  File "/home/danzin/projects/cpython/Lib/traceback.py", line 1045, in __init__
    self.stack = StackSummary._extract_from_extended_frame_gen(
  File "/home/danzin/projects/cpython/Lib/traceback.py", line 492, in _extract_from_extended_frame_gen
    f.line
  File "/home/danzin/projects/cpython/Lib/traceback.py", line 369, in line
    self._set_lines()
  File "/home/danzin/projects/cpython/Lib/traceback.py", line 350, in _set_lines
    lines.append(linecache.getline(self.filename, lineno).rstrip())
  File "/home/danzin/projects/cpython/Lib/linecache.py", line 25, in getline
    lines = getlines(filename, module_globals)
  File "/home/danzin/projects/cpython/Lib/linecache.py", line 41, in getlines
    return updatecache(filename, module_globals)
  File "/home/danzin/projects/cpython/Lib/linecache.py", line 100, in updatecache
    stat = os.stat(fullname)
AttributeError: 'NoneType' object has no attribute 'stat'
Traceback (most recent call last):
  File "/home/danzin/projects/cpython/Lib/runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/danzin/projects/cpython/Lib/runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "/home/danzin/projects/cpython/Lib/_pyrepl/__main__.py", line 6, in <module>
    __pyrepl_interactive_console()
  File "/home/danzin/projects/cpython/Lib/_pyrepl/main.py", line 59, in interactive_console
    run_multiline_interactive_console(console)
  File "/home/danzin/projects/cpython/Lib/_pyrepl/simple_interact.py", line 147, in run_multiline_interactive_console
    statement = multiline_input(more_lines, ps1, ps2)
  File "/home/danzin/projects/cpython/Lib/_pyrepl/readline.py", line 385, in multiline_input
    return reader.readline()
  File "/home/danzin/projects/cpython/Lib/_pyrepl/reader.py", line 773, in readline
    self.handle1()
  File "/home/danzin/projects/cpython/Lib/_pyrepl/reader.py", line 722, in handle1
    input_hook = self.console.input_hook
  File "/home/danzin/projects/cpython/Lib/_pyrepl/unix_console.py", line 552, in input_hook
    if posix._is_inputhook_installed():
AttributeError: 'NoneType' object has no attribute '_is_inputhook_installed'

Not sure this is something that should be guarded against or is just a "then don't do that" case.

If this is deemed worth fixing, we could change _pyrepl.windows_console.[Windows|Unix]Console.input_hook to guard against TypeError and AttributeError, or move the imports to module level. Also it might make sense to guard updatecache in linecache against the AttributeError. But, again, I'm not sure this should be fixed.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, Windows

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Riproduci il problema sostituendo builtins.import nella nuova REPL, quindi esamina _pyrepl/windows_console.py, _pyrepl/unix_console.py e linecache.py in input_hook e updatecache. Confronta la nuova REPL con la REPL di base e determina se gli import interessati o la gestione di traceback debbano tollerare la sostituzione; il lavoro è completo quando l’interprete non termina nei casi segnalati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
cli
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.