zipfile: Deduplicate reinitialization setup for ZipExtFile when seeking
Open
Nobody has claimed this yet.
type-feature
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 35.9k
- PR merge metrics
- PR metrics pending
Description
Feature or enhancement
Proposal:
ZipExtFile needs to be reinitialized if seeking back beyond it's current buffered data. The code to initialize and then reinitialize are in 2 locations and consolidating these into one location reduces the footprint for introducing potential bugs.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
- gh-121640
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the zipfile implementation at ZipExtFile and inspect the two locations that initialize or reinitialize it during seeking. Consolidate those setup paths into one location, then verify that seeking back beyond buffered data still reinitializes correctly; linked PR gh-121640 provides context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100