Uses a higher granularity than seconds for `.pyc` file invalidation
Personne n'a encore pris cette issue.
- Langage dominant
- Python
- Étoiles
- 77.2k
- Forks
- 35.9k
- Métriques de merge des PR
- Métriques de PR en attente
Description
Bug report
Bug description:
reproduction:
#!/bin/sh
mkdir -p src
rm -fr src/__pycache__
rm -fr __pycache__
echo 'from src.test import f' > main.py
echo 'print(f())' >> main.py
echo 'def f():' > src/test.py
echo ' return "Hello!"' >> src/test.py
# prints "Hello!"
python3 main.py
echo 'def f():' > src/test.py
echo ' return "Goodbye!"' >> src/test.py
# also prints "Hello!", but note the file does not say that anymore
python3 main.py
(this is probably sensitive to how fast your computer is)
this seems to stem from (i guess) that the timestamps are 32-bit, and write the current second (unix time, as 32-bit). and then, when the file is edited and the python script runs again, it gets a cache hit (same timestamp as file 32-bit mtime) and yields the old content.
is this known/intended? is there a mitigation that isn't just "delete the pycache"? i tried looking if anyone else ran into this and could not find anything.
i ran into this as part of a workflow that first edited a python script via shell (edits mtime), then invoked python on it (updates pyc to that mtime), then that python invocation updates the same script a second time and those changes were weirdly lost and confused me for a while. after having to delete the pycache a few times, i looked into it and ended up at (seemingly) this issue.
also (not relevant), having not looked at the code, what happens in 2038 when 64-bit file timestamps go over the 32-bit value? will the pyc just wrap around or is there some other planned handling?
maybe this format should be updated to 64-bit milliseconds (this seems.. difficult, maybe a new magic?) (and technically milliseconds can also race, though python is usually not fast enough to hit that), or perhaps the pycache should be invalidated when the mtime matches (but this would loop a bunch of times when the script is ran multiple times on the same second until current time is 1 second later than the filetime)
CPython versions tested on:
3.12
Operating systems tested on:
Linux
Linked PRs
- gh-121502
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Exécutez la reproduction shell avec CPython 3.12 et examinez l’invalidation des .pyc ainsi que la gestion des horodatages impliquées dans le cache d’importation. Comparez le comportement avec le PR lié gh-121502 ; le travail doit être considéré comme terminé lorsque des modifications répétées au cours de la même seconde n’exécutent plus un code source obsolète et que les cas limites pertinents sont couverts.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python
- Domaine
- tooling
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100