python / python/cpython

`_utcfromtimestamp` is undefined in `datetimetester`

未关闭
#120,266 0 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@sobolevn 已经在做这个了。

开始于 2024年6月8日。

tests type-bug
主要语言
Python
星标
77.2k
派生
36k
PR 合并指标
PR 指标待抓取

描述

Bug report

This code cannot run correctly:

https://github.com/python/cpython/blob/55402d3232ca400ebafe4fe3bd70f252304ebe07/Lib/test/datetimetester.py#L6221-L6227

Because _utcfromtimestamp is not defined anywhere.

Introduced in https://github.com/python/cpython/commit/38dc3f28dde92b4fa6284a57f4e554991a3d9276 by @pganssle

I think that this is a typo, I will send a PR.

This was introduced when datetime.utcfromtimestamp was deprecated, I propose to use a direct alternative: datetime.fromtimestamp(t, datetime.UTC)

This problem is not detected by tests, because this looks like a in-test helper for module maintainers. It is not used as of right now.

Linked PRs
  • gh-120267

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。