JIT: map uops with code generated by the JIT
Ninguém assumiu esta issue ainda.
- Linguagem predominante
- Python
- Estrelas
- 77.2k
- Forks
- 35.9k
- Métricas de merge de PRs
- Métricas de PR pendentes
Descrição
Feature or enhancement
Proposal:
This is a follow up feature of https://github.com/python/cpython/issues/117958. That feature exposes just the bare JIT Code of the executor object.
To improve the debug experience of the JIT implementation, a map between the UOp and the generated code should be implemented.
@brandtbucher suggested the following in his comment
Hello, thanks for the PR! It certainly does the job of capturing the machine code generated by the JIT but I was hoping to have a map between the uop byte code and the related machine code similarly to what I was envisaging here
So, I've thought about this, and it should be possible with a couple of tweaks.
Basically, this current PR returns a byte string, which consists of the code for each instruction in sequence, followed by the auxiliary data for each instruction in sequence.
Meaning, for a trace of:
[A, B, C, D]It returns:
b"".join([<A code>, <B code>, <C code>, <D code>, <A data>, <B data>, <C data>, <D data>, <padding>])However, the executor knows the uops that make up its trace. If we
#include "jit_stencils.h", we should be able to usestencil_groups[instruction->opcode].code.body_sizeandstencil_groups[instruction->opcode].data.body_sizeto compute these chunks.Maybe @tonybaloney and @diegorusso can confirm, but it seems like the most useful info to return would be a 3-tuple of base address, a list of code byte strings (corresponding to uops) and a list of data byte strings (again, corresponding to uops).
So, for the above example, the return value would be:
( <base address>, [<A code>, <B code>, <C code>, <D code>], [<A data>, <B data>, <C data>, <D data>], )(I think base address is needed for some absolute addressing that we use in places.)
So each of the code or data lists can be
zip'd with the executor to map them to individual uops. And if I want the raw string of data that this PR returns now, I can just take this tuple and dob"".join(result[1] + result[2]).Would this meet everyone's needs, or am I overthinking it? Even though it's internal, I don't want to tweak this too much after the beta freeze on Monday, so I'm leaning towards providing more information rather than less.
Originally posted by @brandtbucher in https://github.com/python/cpython/issues/117959#issuecomment-2088028660
Has this already been discussed elsewhere?
I have already discussed this feature proposal on Discourse
Links to previous discussion of this feature:
https://discuss.python.org/t/jit-mapping-bytecode-instructions-and-assembly/50809
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Direção de pesquisa
Comece lendo as issues relacionadas 117958 e 117959, a discussão no Discourse e jit_stencils.h. Rastreie como o executor expõe seu código JIT e como stencil_groups fornece os tamanhos do código e dos dados. O trabalho estará concluído quando forem expostos um endereço base e listas de strings de bytes de código e dados por uop que possam ser associados novamente aos uops do executor.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- c, python
- Domínio
- compilers
- Tipo de issue
- Funcionalidade
- Dificuldade
- 5/5
- Tempo estimado
- Mais de uma semana
- Status de atividade
- Estagnada
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 25/100