EmailMessage.get_filename() not unquoting url encodings
Open
Nobody has claimed this yet.
stdlib
topic-email
type-bug
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- PR merge metrics
- PR metrics pending
Description
Bug report
Bug description:
import requests
from email.message import EmailMessage
def get_filename_from_url(url, url_response=None):
if url_response == None:
url_response = requests.get(url)
url_response.raise_for_status()
content_disposition = url_response.headers.get("Content-Disposition")
if content_disposition:
email_message = EmailMessage()
email_message["Content-Disposition"] = content_disposition
return email_message.get_filename()
url = "https://www.gsi.gov.in/webcenter/ShowProperty;jsessionid=yv2xehEKwHR0ZHf64V2sMbrFzRSeSGCvcxDVr9F4_rbXBVtcgKbl!1598077039!1556223610?nodeId=%2FUCM%2FDCPORT1GSIGOVI063041%2F%2FidcPrimaryFile&revision=latestreleased"
get_filename_from_url(url)
output
annoncement_of%20computer%20application%20_rti_er%20_16122014.pdf
if i use
from urllib.parse import unquote
unquote(email_message.get_filename())
i am getting unquoted output
annoncement_of computer application _rti_er _16122014.pdf
why a different unquote function is used in EmailMessage.get_filename() ?
CPython versions tested on:
CPython main branch
Operating systems tested on:
Windows
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the EmailMessage.get_filename() entry point and reproduce the reported Content-Disposition behavior with the provided URL and header value. Compare its decoding behavior with urllib.parse.unquote, then establish the expected filename handling and add or update regression coverage if the issue confirms a bug.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100