unittest.mock.patch of a subclass poisons base class
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Bug report
Bug description:
this is an entirely silly example boiled down from a much more complex one to demonstrate the behaviour. the actual code here is nonsensical (Test2 will always fail) but Test1 should work just fine -- the decoration of the subclass Test2 seems to also decorate Test1's methods unexpectedly
from unittest import mock
s = 0
@mock.patch(f"{__name__}.s", 5)
class Test1:
def test_1(self):
assert s == 5, s
@mock.patch(f"{__name__}.s", 2)
class Test2(Test1): pass
Test1().test_1()
$ python3.12 t2.py
Traceback (most recent call last):
File "/Users/asottile/workspace/sentry/t2.py", line 14, in <module>
Test1().test_1()
File "/opt/homebrew/Cellar/python@3.12/3.12.2_1/Frameworks/Python.framework/Versions/3.12/lib/python3.12/unittest/mock.py", line 1387, in patched
return func(*newargs, **newkeywargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/asottile/workspace/sentry/t2.py", line 8, in test_1
assert s == 5, s
AssertionError: 2
the problem appears to be here: https://github.com/python/cpython/blob/ea94b3b149eeadf33c2f7c46f16dcda0adc7cf4e/Lib/unittest/mock.py#L1412
whereas I think it should always return a new callable instead of mutating a potentially unrelated method
CPython versions tested on:
3.12
Operating systems tested on:
macOS
Linked PRs
- gh-117665
- gh-117667
- gh-117687
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
執行提供的 Python 3.12 reproducer,並檢查 Lib/unittest/mock.py 第 1412 行附近的位置,issue 在此指出了有問題的行為。在進行變更前,先檢閱相關 PR gh-117665、gh-117667 和 gh-117687;當對子類別進行 patch 不再改變透過 Test1 觀察到的繼承方法行為時,即表示完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- testing-qa
- Issue 類型
- 缺陷
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 活躍度
- 停滯
- 描述清晰度
- 描述清楚
- 新手友好度
- 25/100