Dual declaration of directories in Makefile is a foot gun
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
I'd estimate that 90% of the times that I introduce a new directory to the Python project, I forget that Python requires a two-phase operation to add new directories:
- Add the directory and files to the Git repo.
- Add a reference to the new directory to the Makefile.
If one completes only the first step, the tests will pass locally and in CI, but will fail in buildbots after merging. See https://github.com/python/cpython/pull/102010 for the most recent example.
Ideally, the build system should be reconfigured such that only one phase is required to add a new directory to the build.
Short of that, the CI builds should somehow check that the introduction of a new directory either triggers the buildbot "installed" builds or otherwise checks that the new directories are included in any source bundle.
It should not be a common occurrence to introduce a directory, pass CI, and then fail buildbots.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
先檢查 Makefile,以及 issue 中提到的 buildbot "installed" 建置或 source-bundle 檢查。確認建置是否能自動發現新目錄,或 CI 是否能偵測出建置中缺少的目錄,然後使用一個新引入的目錄驗證所選的方法。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- build-system, ci-cd
- Issue 類型
- 功能
- 難度
- 5/5
- 預估耗時
- 一週以上
- 活躍度
- 停滯
- 描述清晰度
- 需要釐清
- 新手友好度
- 35/100