subprocess should quote `comspec` when forming its `args` string
Open
Nobody has claimed this yet.
stdlib
topic-subprocess
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- PR merge metrics
- PR metrics pending
Description
The value of args should quote comspec. Otherwise the shell process won't parse its command line correctly if comspec contains spaces.
Originally posted by @eryksun in https://github.com/python/cpython/pull/101712#discussion_r1100761091
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names subprocess argument construction and the comspec value, but no file or test. Start by tracing where the subprocess args string is formed and inspect Windows-specific subprocess coverage. Done means comspec paths containing spaces are quoted so the shell parses the command line correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100