Specialize long tail of binary operations using a table.
@brandtbucher 已经在做这个了。
开始于 2022年12月14日。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 36k
- 平均合并
- 1 天 9 小时
- 30 天内合并 PR
- 558
描述
There is a desire to specialize the remaining binary operations (including binary subscript).
However adding more and more specialized instructions is likely to make performance worse.
This idea is to have a lookup table of types pairs and function pointers. This is less efficient than inlining the code, but more extensible.
A single instruction can then support up to 256 specializations.
This will only work for immutable classes.
struct table_entry {
PyTypeObject *left;
PyTypeObject *left;
binaryfunc *func;
};
TARGET(BINARY_OP_TABLE) {
PyObject *lhs = SECOND();
PyObject *rhs = TOP();
Cache *cache = GET_CACHE();
struct table_entry* entry = &THE_TABLE[cache->table_index];
DEOPT_IF(Py_TYPE(lhs) != entry->left);
DEOPT_IF(Py_TYPE(rhs) != entry->right);
PyObject *res = entry->func(lhs, rhs);
if (res == NULL) {
goto error;
}
STACK_SHRINK(1);
Py_DECREF(lhs);
Py_DECREF(rhs);
SET_TOP(res);
DISPATCH();
}
An ancillary mapping of (left, right) -> index will be needed for efficient specialization.
It is probably worth keeping the most common operations int + int, float + float, etc. inline.
We can replace BINARY_SUBSCR with BINARY_OP ([]) to allow effective specialization of BINARY_SUBSCR
E.g. subscripting array.array[int] can be handled with the registration mechanism described below.
Registering binary functions at runtime
https://github.com/faster-cpython/ideas/discussions/162
Linked PRs
- gh-128722
- gh-128927
- gh-128956
- gh-128963
- gh-129379
- gh-129431
- gh-129700
- gh-132068
- gh-132093
- gh-132230
- gh-132383
- gh-132626
- gh-144826
- gh-148146
- gh-148791
- gh-149413
- gh-149458
- gh-156324
- gh-156918
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。