python-hyper / python-hyper/rfc3986
rfc3986 uses its own deprecated method - warning spam
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 189
- Forks
- 38
- Avg merge
- 13h 36m
- Merged PRs (30d)
- 1
Description
In Version 2.0, in URIMixin.resolve_with() rfc3986 uses the deprecated URIReference.is_valid() instead of a Validator.
Apart from it being a bad look, it causes literally thousands of warnings in our pipeline (since resolve_with() is used often from the json-schema and jschon packages) - see below. This spams our logs and can make it hard to debug.
I made a fix: https://github.com/jpmaterial/rfc3986/tree/release/2.0 (and verified it), but there is no branch that offers itself for a pull request.
Are you interested in the fix (and releasing a 2.0.1 I guess) and if yes, on which branch should I request a pull?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the URIMixin.resolve_with() implementation and inspect how it calls URIReference.is_valid(). Replace the deprecated validation path with a Validator, then run the relevant project checks and confirm that the warning spam is gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100