python-hyper / python-hyper/brotlicffi

Compressor.compress() can fail if not flushed frequently

Open
#167 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
154
Forks
34
Avg merge
1d 1h
Merged PRs (30d)
3

Description

Need to call BrotliCompressorTakeOutput during compression stage

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Compressor.compress() and trace the compression stage where BrotliCompressorTakeOutput is currently omitted. Confirm how output is collected during compression, then verify that calling it prevents failures when compression is not flushed frequently. The payload names no test file, so identify the relevant compression test before making the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.