pulp / pulp/pulp_python

Python Remote URL construction incorrectly appends `/simple/`, breaking Gitea PyPI integration

Aperta
#868 1 commento 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Issue
Lingua principale
Python
Stelle
49
Fork
88
Merge medio
1g 10h
PR unite (30g)
31

Descrizione

Version

  • Pulp Operator: v1.0.0

Describe the bug

The pulp-python plugin unconditionally appends the /simple/ suffix to the url provided for a Python remote. This behavior is hardcoded and assumes the remote URL points to a repository root that needs /simple/ added to reach the PEP 503 index.

This assumption breaks compatibility with PyPI-compatible registries like Gitea, where the complete, non-modifiable simple index URL is already provided. The forced suffix leads to incorrect URL generation.

To Reproduce
* Gitea Instance with a PyPI Registry: e.g., https://gitea.example.xyz
* Target Gitea PyPI URL: https://gitea.example.xyz/api/packages/example/pypi/simple/

  • Attempt 1: Provide the full, correct URL ending in /simple/

      pulp python remote create \
          --name gitea-remote-full \
          --url https://gitea.example.xyz/api/packages/example/pypi/simple/ \
          --username <user> \
          --password <pass>
      
      pulp python repository create --name test-repo-1
      pulp python repository sync --name test-repo-1 --remote gitea-remote-full
    
  • Attempt 2: Provide the URL without the /simple/ suffix

      pulp python remote create \
          --name gitea-remote-base \
          --url https://gitea.example.xyz/api/packages/example/pypi \
          --username <user> \
          --password <pass>
    
      pulp python repository create --name test-repo-2
      pulp python repository sync --name test-repo-2 --remote gitea-remote-base
    

Pulp's automatic suffixing logic causes 404 errors in both scenarios.

  1. In Attempt 1, Pulp appends an extra /simple/, resulting in a "double suffix":

    • URL requested: https://gitea.example.xyz/api/packages/example/pypi/simple/simple/
    • Result: 404 Not Found.
  2. In Attempt 2, Pulp strips the last path segment (/pypi) and appends /simple/, also forming an incorrect URL:

    • URL requested: https://gitea.example.xyz/api/packages/example/simple/
    • Result: 404 Not Found.

Expected behavior
Pulp should respect the provided url for a Python remote. When a URL is provided, Pulp should either:
a. Use the URL as-is, without modification.
b. Check if the URL already ends with /simple/ and, if so, refrain from appending it again.

For the configuration in Attempt 1, Pulp should make requests directly to https://gitea.example.xyz/api/packages/example/pypi/simple/.

Additional context
This behavior makes it impossible to use Gitea as a PyPI remote source for Pulp. More broadly, it limits Pulp's compatibility with any PyPI-compliant repository that provides a full, unchangeable URL to its simple index and does not conform to the exact .../ -> .../simple/ transformation that Pulp enforces.

A fix should be relatively easy: Modify the URL construction logic to first check if url.endswith('/simple/'). If true, use the URL as-is

This would provide the necessary flexibility to integrate with a wider range of non-standard but popular PyPI-compatible endpoints like Gitea.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Start by tracing the Python remote URL construction logic that appends /simple/; no source file or test path is identified in the issue. Reproduce both Gitea URL cases, then add coverage showing that a complete /simple/ URL is requested unchanged and that the resulting requests no longer return 404.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
backend
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.