incorrect assertions in test specs

Aberta
#176 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
48/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Estagnada
Stack de tecnologia
powershell
Domínio
testing-qa

Direção de pesquisa

Start in spec/testfiles/syntax_test_TheBigTestFile.ps1 at the referenced ranges around lines 428, 569, 771, and 1181. Compare each assertion with the semantics described in issues #112, #62, and #132, then correct the misleading expectations and run the relevant spec tests to confirm the assertions match the grammar.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

This is to point out some incorrect assertions in the spec tests.

https://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L428-L430

The ++ is actually the unary increment operator, and PowerShell will flag this as an error because it cannot be used on a constant.
image

https://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L569-L571

These are not operators in these instances, so even though the grammar scopes them as such, asserting these tests is misleading and will require correcting when the grammar is improved. This is covered in issue #112.

https://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L771-L776

The # is this spec is not a line comment token. Its actually part of an unquoted non-expanding string that describes a function/command name. This is covered in issue #62.

(Example under PR #156)
image

https://github.com/PowerShell/EditorSyntax/blob/44eac8702f3cbe55a4ec70c1fdb163d42b4162fc/spec/testfiles/syntax_test_TheBigTestFile.ps1#L1181-L1187

Line 1186 specs the $ as definition.variable. This is covered in issue #132.

(Example under PR #156 I have scoped it as punctuation.section.embedded.begin)
image

This might only be a partial listing. This is some of the specs I am constantly looking at when checking my work. I list these more so that others can avoid needing to question these.

Linguagem predominante
PowerShell
Estrelas
151
Forks
55
Nenhum PR com merge em 30d

Guia de contribuição

Abrir o guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de PowerShell/EditorSyntax

Todas as issues de PowerShell/EditorSyntax

Issues semelhantes

Mais issues de Testing & QA

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.