Renderer rows silently corrupt Kitty APC graphics escapes — blocks inline images from mods
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 45/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Stack de tecnologia
- typescript
- Domínio
- cli
Direção de pesquisa
Comece com o kitty-graph-repro.ts anexado e inspecione o pipeline de linhas do renderer, incluindo seu calculador de largura e sanitizador de linhas. Compare escritas diretas em fd com APCs retornados como linhas e, em seguida, verifique no ambiente kitty especificado se sequências APC completas e divididas em chunks sobrevivem ao repaint sem corrupção ou intercalação.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Summary
Mod renderer rows silently corrupt Kitty Graphics Protocol (APC) escape sequences, making inline images impossible from mods even though the docs promise row styling with raw codes (api.md: "style them with ansi escapes — picocolors, @commandcode/tui helpers, or raw codes"). SGR escapes survive; multi-line APC payloads do not. This bug blocks any cmd.ui.image()-style feature (see #633 §7) and any mod that talks to a terminal graphics protocol.
Repro (mod-side, minimal)
A mod registers a renderer whose first row is a complete kitty APC (\x1b_Gf=100,q=1,a=T,...;<base64>\x1b\\). The same bytes written directly to fd 1 draw the image; the same bytes returned as a renderer row never draw. Verified today on kitty 0.42 with a browser-rendered PNG (784×62), all in a live session:
| Delivery | Result |
|---|---|
writeSync(1, apc) from inside the renderer |
image draws |
| APC as first renderer row, 4096-byte payload | no image (row wraps at terminal width → sequence corrupted) |
APC split into 96-byte / 64-byte row chunks, chained with m=1/m=0 |
still no image |
Root cause (two layers)
- Wrap corruption: a KB-scale APC cannot fit one terminal line; the feed wraps long rows at the column width, splitting the sequence mid-payload. Kitty silently drops malformed graphics sequences when
q=1— no error reaches the mod or the user. - Chunk-chain interleaving: splitting into line-sized chunks per the protocol's own
m=continuation mechanism doesn't help either — the feed joins rows with\nand full-screen repaints can split the chain across writes, and interleaved bytes between continuation chunks invalidate the transmission (again silently).
The SGR-red-caption probe proved the pipe itself passes escapes — the chain specifically dies between chunks.
What would fix it
Either of:
- APC passthrough in the row pipeline — treat
\x1b_G…\x1b\\as an atomic zero-width unit in the width calculator and row sanitizer (the same allowance SGR already gets), so a chain of line-sized APCs rides the row stream intact. Mod-side we already chunk to 64-byte rows precisely for this. - A first-class image API — e.g.
cmd.ui.image({ path, rows })that owns protocol detection, chunking, placement, and repaint behavior (would supersede/fold into #633 §7cmd.ui.image(); this issue supplies the pipeline groundwork it needs).
Until then, mods must fall back to writing directly to fd 1, which draws the image but anchors it to whatever the cursor happens to be at render time — placement drifts relative to the feed block (phantom padding), and it breaks under scroll.
Environment
- Command Code 1.37.0 (npm global)
- kitty 0.42,
TERM=xterm-kitty, interactive TTY (graphics protocol verified working via raw fd write) - Repro mod:
kitty-graph-repro.ts(attached to this issue) — encoder, capability gate, and both delivery strategies; the Delivery A/B switch is a one-line change in the renderer
Related
- #633 §7 —
cmd.ui.image()feature request (the umbrella this bug blocks) - #609 — adjacent: feed rendering surface limitations for mods
- Linguagem predominante
- Sem dados de linguagem
- Estrelas
- 4k
- Forks
- 350
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Guia de contribuição
Nenhum guia de contribuição indexado para este repositório
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de CommandCodeAI/command-code
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
CommandCodeAI/command-code#855 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
CommandCodeAI/command-code#841 · 1 comentário ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
CommandCodeAI/command-code#655 · 1 comentário ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
CommandCodeAI/command-code#608 ·
-
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 70/100
CommandCodeAI/command-code#893 ·
Todas as issues de CommandCodeAI/command-code
Issues semelhantes
-
Accept -c in more positions Abertaarea: compat bug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 72/100
-
area: dogs bug priority: P3 silent failure test-code
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 88/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
phoenixframework/phoenix#6847 ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 85/100
hust-open-atom-club/hustmirror-cli#52 · 1 comentário ·