Mod slash commands that open UI require Enter twice from the slash menu

Aberta
#744 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
3-5 dias
Facilidade para iniciantes
72/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
typescript
Domínio
api, cli, testing-qa

Direção de pesquisa

Comece pelo contrato de registro de comandos de mod e pelo handler de Enter do slash-menu; em seguida, rastreie como o comando e a descrição chegam aos itens do menu. Adicione o estado de execução opt-in, preservando a inserção com Tab e Right Arrow. Verifique os casos de regressão listados, incluindo a execução no primeiro Enter, a conclusão normal de comandos e o comportamento inalterado de /model.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Mod slash commands that open UI require Enter twice from the slash menu

Summary

Selecting a mod-provided slash command from the TUI slash menu requires two Enter presses before its handler runs. The first Enter only inserts the completed command into the input; the second Enter dispatches it. Built-in picker commands such as /model run on the first Enter.

This makes UI-only mod commands feel less integrated and contradicts the slash-command documentation, which says Enter runs the selected command while Tab or Right Arrow inserts it.

Expected behavior

A mod command explicitly marked as action-only / execute-on-select should run its handler on the first Enter, allowing a cmd.ui.select() dialog to open immediately like /model.

Tab and Right Arrow should continue to insert the command for editing without executing it.

Actual behavior

The first Enter completes and inserts the mod command with a trailing space. The handler is only called after a second Enter. There is no public addCommand option that lets a mod opt into the built-in picker behavior.

Minimal reproduction

import type {ModApi} from '@commandcode/harness';

export default function (cmd: ModApi): void {
  cmd.addCommand({
    name: 'picker-test',
    description: 'Open a test picker',
    handler: async () => {
      await cmd.ui.select({
        title: 'Test picker',
        options: [{label: 'One'}, {label: 'Two'}],
      });
    },
  });
}
  1. Start cmd --mod ./picker-test.ts.
  2. Type /picker-test or select it from the slash menu.
  3. Press Enter once.
  4. Observe that the picker does not open and the command is merely inserted.
  5. Press Enter again; the picker opens.
  6. Compare with /model, which opens its picker on the first Enter.

Environment

  • Command Code 1.32.2 (latest npm release at time of report)
  • Linux
  • Bash

Technical analysis

The runtime keeps built-in picker commands such as /model in a private BARE_OPENS_PICKER_BUILTIN_SLASH_COMMANDS set. The input dispatcher bypasses completion for members of that set and invokes them immediately.

Mod command menu items only carry command and description, and the public command registration contract is currently {name, description?, argumentHint?, handler}. Consequently, a mod cannot request the same execution mode. transformInput is not a workaround because slash commands and individual keypresses do not route through it.

Suggested API and implementation

Add an explicit opt-in field, for example:

cmd.addCommand({
  name: 'picker-test',
  description: 'Open a test picker',
  executeOnSelect: true,
  handler: async () => { /* open UI */ },
});

Then:

  1. Preserve executeOnSelect in the mod host's command menu items.
  2. In the slash-menu Enter handler, dispatch such an item immediately.
  3. Keep Tab and Right Arrow as insertion-only actions.
  4. Keep the existing completion behavior as the default for backward compatibility.

Suggested regression coverage:

  • a mod command with executeOnSelect: true runs exactly once on the first Enter;
  • a normal mod command retains its existing completion behavior;
  • Tab and Right Arrow never execute either kind;
  • built-in /model behavior remains unchanged.

Real-world case

command-code-external-providers registers /external-providers, whose handler immediately opens a provider/model picker. It currently needs the extra Enter even though it has no arguments and behaves like a built-in picker command.

Linguagem predominante
Sem dados de linguagem
Estrelas
4k
Forks
350
Métricas de merge de PRs
Nenhum PR com merge em 30d

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de CommandCodeAI/command-code

Todas as issues de CommandCodeAI/command-code

Issues semelhantes

Mais issues de Backend & API Design

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.