write_to_textfile: tmp file is left behind if generator code fails

In the write_to_textfile function, the code to run the collector registry is in the temp file creation block: https://github.com/prometheus/client_python/blob/master/prometheus_client/exposition.py#L202-L203

In my case, I had an error in my collector code (run by generate_latest(registry)). This resulted in many tmp files left over from the errors.

I'm wondering if it would be preferable to run the code before the temp file block, e.g.:

    tmppath = '%s.%s.%s' % (path, os.getpid(), threading.current_thread().ident)
    out = generate_latest(registry)
    with open(tmppath, 'wb') as f:
        f.write(out)
    # rename(2) is atomic.
    os.rename(tmppath, path)

Unless leaving temp files behind is the desired/intended behavior.

Inizia in prometheus_client/exposition.py, nell’implementazione di write_to_textfile intorno alle righe 202-203, dove generate_latest(registry) viene eseguito durante la creazione del file temporaneo. Traccia il percorso dell’errore quando il codice del collector solleva un’eccezione e verifica che il comportamento risultante non lasci alcun file temporaneo e mantenga il flusso di rinomina atomica.