prometheus / prometheus/client_python
can no longer subclass prometheus_client.twisted.MetricsResource
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.4k
- Forks
- 876
- Avg merge
- 8d 4h
- Merged PRs (30d)
- 1
Description
In Twisted resources are designed to be subclassed.
Now that MetricsResource is hidden behind a lambda, it can no longer be subclassed.
Can you provide a easy way to subclass the handler?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating prometheus_client.twisted.MetricsResource and the lambda that now hides it. Check how Twisted resources are subclassed and verify the result with an appropriate subclassing test; done means users can subclass the handler through a clear public interface.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- prometheus, python
- Domain
- backend, observability-sre
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100