processing / processing/processing-website

Serial.write documentation errors.

Abierto
#352 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
MDX
Estrellas
90
Forks
122
Merge medio
1 h 43 min
PR fusionados (30 d)
3

Descripción

Description

  1. The reference for Serial.write implies that you can have one or more parameters of type byte[], String or int. As far as I can see it accepts only one parameter (of any of those types).

The method write(int) in the type Serial is not applicable for the arguments (String, int)
The method write(int) in the type Serial is not applicable for the arguments (int, String)

  1. Serial.write with integer parameter sends only the least-significant byte.

Assuming that serial.write(int-var) is valid, although not an example in Processing-4 (it was an example in Processing-3). It sends only the least-sig byte. Maybe this is as intended, but the reference doesn't say that so you'd expect the whole integer, all 4 bytes, to be written.

Expected Behavior

I'd expect the serial.write() to accept all the formats given in the reference. Assuming that the code is working correctly, then the reference should have examples of each possibility write(byte[]), byte, String, int. (I've only tested int.) No examples with multiple parameters.

I'd expect write(int) to send the whole integer, or if the help states that it only sends the least-sig byte, then 1 byte will do.

Current Behavior

Serial.write does not accept the reference multi-parameter examples.

The method write(int) in the type Serial is not applicable for the arguments (int, String)
The method write(int) in the type Serial is not applicable for the arguments (String, int)

Serial.write(int) sends only the least-sig byte.

Steps to Reproduce

Processing code.

  • Comment in lines 28,29 and they are not accepted.
  • Sends int to Ard at 1Hz. Prints out the returned text.) You can see that Ard is getting only the least sig-byte.
final boolean T = true;
final boolean F = false;

import processing.serial.*;

Serial port; 

byte b1;
int i1 = 0;
long l1;

void setup() {
  frameRate(10);
  size(140, 80);
  port = new Serial(this, "COM13", 9600);
  noStroke();
  smooth();
}



void draw() {
  boolean inComing = F;
  char ch;
  if (frameCount > 50 && frameCount % 10 == 0) {
    b1 = (byte) i1;
    l1 = i1;

    //port.write(i1, "");
    //port.write("", i1);    
    
    port.write(i1);
    print(String.format("X %d ",l1));
    i1 += 53;
  }
  if (port.available() > 0)  {print("R "); inComing = T; delay(10);}
  while (port.available() > 0)
  {
    ch = (char) port.read();
    print(ch);
  }
  if (inComing) {print(" "); inComing = F;}
}

Arduino Code

#define pM pinMode
#define dW digitalWrite

int i1;
int led = 7;

void setup()
{
  Serial.begin(9600);

  Serial.println();
  Serial.println(__FILE__);
  Serial.println(__DATE__);
  Serial.println(__TIME__);


  pM(led, OUTPUT);
}

void loop()
{  
  dW(led, 0);
  if (Serial.available() > 0) {
    i1 = Serial.read(); 
    dW(led, 1);
    Serial.print(i1);
  }
  delay(10);
}

Output:

X 0 R 0 X 53 R 53 X 106 R 106 X 159 R 159 X 212 R 212 X 265 R 9
X 318 R 62 X 371 R 115 X 424 R 168 X 477 R 221 X 530 R 18
X 583 R 71 X 636 R 124 X 689 R 177 X 742 R 230 X 795 R 27
X 848 R 80 X 901 R 133

X is the value Processing has, continues increasing. Arduino is sending back value of only 1 byte, limited to 255.

Your Environment

Windows-10, Processing 4.0b3, Ard 1.8.5, Ard-Nano.

Possible Causes / Solutions

Which is right, the serial.write() behaviour, or the reference? Why was the documentation changed between Processing 3 and 4. The easy solution is to make the reference match the current behaviour. Only 1 parameter of 3 types.

For the write(int) add the reference line, something like "with an integer parameter the least-significant byte is sent (value 0..255).

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Abre la referencia enlazada de Serial.write y compara sus ejemplos de parámetros con el comportamiento de un solo argumento que muestran el sketch de Processing y la salida de Arduino. Actualiza la referencia para que las firmas compatibles y el comportamiento del byte menos significativo sean precisos; después, verifica que los ejemplos ya no afirmen llamadas con múltiples parámetros.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
arduino
Área
documentation, embedded-iot
Tipo de issue
Documentación
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.