prettier / prettier/plugin-php
ugly nested retif with binary
Open
Nobody has claimed this yet.
enhancement
ugly
- Dominant language
- PHP
- Stars
- 1.9k
- Forks
- 139
- PR merge metrics
- No merged PRs in 30d
Description
Prettier 1.14.3
PHP Plugin 0.9.0
Input:
return 1 == $number % 10 && 11 != $number % 100
? 0
: ($number % 10 >= 2 &&
$number % 10 <= 4 &&
($number % 100 < 10 || $number % 100 >= 20)
? 1
: 2);
Output:
return 1 == $number % 10 && 11 != $number % 100
? 0
: ($number % 10 >= 2 &&
$number % 10 <= 4 &&
($number % 100 < 10 || $number % 100 >= 20)
? 1
: 2);
Expected behavior:
return 1 == $number % 10 && 11 != $number % 100
? 0
: ($number % 10 >= 2 &&
$number % 10 <= 4 &&
($number % 100 < 10 || $number % 100 >= 20)
? 1
: 2);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the PHP input and comparing the current output with the expected output shown in the issue. Trace the formatter's handling of nested ternary expressions combined with binary operators, then add a regression case whose formatted result matches the expected indentation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100