populationgenomics / populationgenomics/references
Failure to detect small resource changes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2
- Forks
- 2
- Avg merge
- 19m
- Merged PRs (30d)
- 2
Description
The CI process takes the previous and current states of the resources file, and performs the following check on each Source:
- Is the source new
- Has the source URL changed
- Has the destination URL changed
- Is the destination bucket absent
If these are True, nothing is copied. This fails to spot the situation in #31 where the sources and destinations are the same, but the content is moved around, or new files are required from previously existing sources. In this PR a whole bunch of data was added in files, but that is not checked by this process, so no transfer is initiated.
In this instance it's a happy coincidence that the discrepant files had previously been sync'd over, they just weren't present in config.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/prep_matrix.py lines 22-27 and compare how previous and current resource states are checked. Trace how the files entries are represented and determine how changes to existing sources or newly required files should trigger a transfer; done means the CI process detects the discrepancy described in #31.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100