popcodeorg / popcodeorg/popcode

Error Detection Creates False Positives if Non-US Keyboard Characters Used

未关闭
#341 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

bug
主要语言
JavaScript
星标
191
派生
143
平均合并
4 天 11 小时
30 天内合并 PR
5

描述

In our class today a student's chromebook was, for some reason, set to use the international keyboard setting.

As a result she got an error nag about needing to use "s for her href attribute because the double-quotes were typed with international characters. The tag was visibly correct. Switching the chromebook to US Keyboard setting fixed the issue with visibly different " characters in the IDE.

Valid: <img src="//placekitten.com/100/100">
Not valid (US international keyboard): <img src=¨//placekitten.com/100/100¨>

The W3C validator gives the following error for on that character:

Line 2, Column 18: an attribute value must be a literal unless it contains only name characters
<img src=¨//placekitten.com/100/100¨>

You have used a character that is not considered a "name character" in an attribute value. Which characters are considered "name characters" varies between the different document types, but a good rule of thumb is that unless the value contains only lower or upper case letters in the range a-z you must put quotation marks around the value. In fact, unless you have extreme file size requirements it is a very very good idea to always put quote marks around your attribute values. It is never wrong to do so, and very often it is absolutely necessary.

https://github.com/popcodeorg/popcode/issues/179

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

未指定源文件或测试。以 issue #179 为背景,在编辑器中重现所报告的代码片段,并跟踪针对国际键盘引号字符的错误检测路径;当看起来有效的输入不再产生误报,同时真正无效的标记仍会被报告时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
frontend, web-dev
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
30/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。