popcodeorg / popcodeorg/popcode
One true development environment fails when directory has spaces in it
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 191
- Forks
- 143
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 5
Description
Describe the bug
Issue occurs when attempting to run tools/setup.py in a directory that has spaces in it.
Directory is as follows: /Users/jessewang/Documents/Personal Code/popcode
Example Stacktrace:
tools/setup.py
* Install prebuilt node (10.16.2) ..... done.
bash: line 1: /Users/jessewang/Documents/Personal: No such file or directory
bash: line 1: /Users/jessewang/Documents/Personal: No such file or directory
/Users/jessewang/.nvm/versions/node/v8.12.0/bin/yarn -> /Users/jessewang/.nvm/versions/node/v8.12.0/lib/node_modules/yarn/bin/yarn.js
/Users/jessewang/.nvm/versions/node/v8.12.0/bin/yarnpkg -> /Users/jessewang/.nvm/versions/node/v8.12.0/lib/node_modules/yarn/bin/yarn.js
+ yarn@1.17.3
added 1 package in 0.315s
bash: line 1: /Users/jessewang/Documents/Personal: No such file or directory
error popcode@0.9.0: The engine "node" is incompatible with this module. Expected version "~10.16.2". Got "8.12.0"
error Found incompatible module.
To Reproduce
- Store the popcode repo in a folder that has spaces in it.
- Run
tools/setup.py
Expected behavior
tools/setup.py successfully runs and sets the node environment to the correct version.
- OS: iOS
- Version: Current master branch
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tools/setup.py and reproduce the failure by placing the popcode repository in a path containing spaces, then run the setup command. Check how the script invokes bash and configures the prebuilt Node version; done means setup completes from that path and selects Node 10.16.2 as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bash, javascript, node.js, python
- Domain
- build-system, developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100