Choropleth maps only render the first feature with a matching featureidkey, not all matching features
未关闭
还没有人认领这个 Issue。
bug
P3
- 主要语言
- Python
- 星标
- 18.8k
- 派生
- 2.8k
- 平均合并
- 16 小时 26 分钟
- 30 天内合并 PR
- 21
描述
When px.choropleth() is called with a GeoJSON feature collection containing multiple features matching a single featureidkey value, only the first feature is rendered. I believe all features should be so rendered.
The following code generates two images: the first renders all four features, while the second renders only three. The first uses a featureidkey unique to all features, the second uses a featureidkey that is not unique -- only the first feature to match is rendered. :-(
#!/usr/bin/env python3
import pandas as pd
import plotly.express as px
# A simple GeoJSON with four features.
# Each feature has a district.
# One district has two features.
geojson = {
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {
"name": "Alpha",
"district": "One",
},
"geometry": {
"type": "Polygon",
"coordinates": [[[0, 0], [0, 5], [5, 5], [5, 0], [0, 0]]],
},
},
{
"type": "Feature",
"properties": {
"name": "Bravo",
"district": "One",
},
"geometry": {
"type": "Polygon",
"coordinates": [[[5, 0], [5, 5], [10, 5], [10, 0], [5, 0]]],
},
},
{
"type": "Feature",
"properties": {
"name": "Charlie",
"district": "Two",
},
"geometry": {
"type": "Polygon",
"coordinates": [[[0, 5], [0, 10], [5, 10], [5, 5], [0, 5]]],
},
},
{
"type": "Feature",
"properties": {
"name": "Delta",
"district": "Three",
},
"geometry": {
"type": "Polygon",
"coordinates": [[[5, 5], [5, 10], [10, 10], [10, 5], [5, 5]]],
},
},
],
}
districts = {
f["properties"]["name"]: f["properties"]["district"] for f in geojson["features"]
}
# A simple dataframe relating names and districts from the above GeoJSON data.
# i.e., [{'name': 'Alpha', 'district': 'One'}, ...]
data = [f['properties'] for f in geojson['features']]
df = pd.DataFrame(data)
# This code generates two maps from the data:
# * The name map shows all four squares in the same color (count = 1)
# * The district map shows _three_ squares, one with one color (count = 2) and two with another color (count = 1)
# What I expected:
# * The district map should show all four squares, two with light color and two with dark
for key in ["name", "district"]:
region_counts = df.groupby([key], observed=False).size().reset_index(name="count")
fig = px.choropleth(
region_counts,
geojson=geojson,
fitbounds='geojson',
locations=key,
color="count",
featureidkey=f"properties.{key}",
)
fig.write_image(f"mwe-{key}.png")
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
复现所提供脚本中的两个 px.choropleth() 调用,通过 locations 和 featureidkey 比较唯一名称与重复的地区值。跟踪 choropleth 入口点和 GeoJSON feature 匹配,然后在保留唯一名称结果的同时渲染地区地图中的全部四个多边形,以验证完成情况。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- data-visualization
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 28/100