Inconsistent row and col parameters used to add vline to faceted subplots
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Python
- Sterne
- 18.8k
- Forks
- 2.8k
- Ø Merge
- 16 Std. 26 Min.
- Gemergte PRs (30 T.)
- 21
Beschreibung
I'm trying to have a vertical line added to faceted plots, with the line being at a different position for every subplot. Here's a MRE:
import plotly.express as px
import pandas as pd
import numpy as np
from itertools import product
# Prepare data
combinations = list(product(range(1, 11), repeat=2))
df = pd.DataFrame(combinations, columns=['cat', 'x'])
df['y'] = np.random.randint(1, 100, size=len(df))
# Figure
fig = px.line(df, x='x', y='y', facet_col='cat', facet_col_wrap=3)
# Add vlines in a loop
def generate_lines(n, d):
tuples_list = []
a = 1 # Initial value for a
b = 1 # Initial value for b
for i in range(1, n+1):
tuples_list.append((i, a, b))
if i % d == 0: # Check if the divider is reached
a += 1 # Increment a when the divider is reached
b = 1 # Reset b to 1 when the divider is reached
else:
b += 1 # Increment b otherwise
return tuples_list
lines = generate_lines(10, 3)
for i, a, b in lines:
fig.add_vline(x=i, row=a, col=b, opacity=1, line_width=2, line_dash='dash', line_color='red')
fig.show()
What this code should produce is a vertical line at the value of the cat parameter but this is obviously not the case:
It took me a while to figure out what's actually happening. The issue is that the row argument does not start at the top left in the same way as faceting does, but instead starts at the bottom left. As a result, the (1,2) plot with a value of 2 is not shown because that's an empty space (would correspond to cat=11) and the 2nd subplot does not receive their vertical line.
This leads to inconsistencies and the required code to make the location more complicated because e.g. reducing the number of categories to 9 would mean that (1,1) needs to suddenly get a value of 7.
The behavior would be more intuitive if row 1 was the top one instead of the bottom one. If this is not a bug but a feature, it would be good to have this explicitly stated in the documentation / API reference.
Using plotly 5.13.0
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, das bereitgestellte MRE mit plotly 5.13.0 zu reproduzieren, und konzentriere dich darauf, wie facet_col_wrap die Zeilen der Subplots zuweist und wie add_vline row und col interpretiert. Untersuche das von diesen APIs offengelegte Verhalten von Facets und Subplot-Zeilen/-Spalten. Als erledigt gilt die Aufgabe, wenn entweder die Zeilennummerierung dem Faceting-Layout entspricht oder die Dokumentation/API-Referenz das bestehende Verhalten und seinen Workaround klar erklärt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- data-visualization
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100