make "minus sign" configurable
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 18.3k
- Forks
- 2k
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 28
Description
I have found commits where the current minus-sign is intentionally hardcoded as it is, and as a constant.
i don't understand the reasoning for selecting this minus sign since for example in german we would rather show the smaller minus sign "-"
d3.locale would support selecting any character as a minus sign https://github.com/d3/d3-format#formatLocale
i can try a patch if this is something you want to make configurable. and if someone can give me a pointer where such a configuration option would best be placed (locale related?)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by locating the hardcoded minus sign and reviewing how d3-format locale configuration is integrated; then identify where a locale-related option belongs. Done means the minus sign can be selected through configuration and the relevant formatting behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- d3js, javascript
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100