plotly / plotly/plotly.R

The event_data function does not work correctly with cache

Open
#2,134 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

Hello,

Currently the event_data function only checks the session$userData$plotlyShinyEventIDs list if the event exists. This means that a plot that has been rendered from the cache is not included in the list.

Reviewing the code, I think it should also be verified in the names of the session$userData$plotlyInputStore reactive list. With the objective that quite uncomfortable warnings do not appear when executing an application with cache.

Greeting

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the event_data function and inspect how it checks session$userData$plotlyShinyEventIDs and the session$userData$plotlyInputStore reactive list. Reproduce the behavior with a cached plot, then verify that cached events are handled without the reported warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.